Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DomainInternal to status for Route and Service #1586

Merged
merged 9 commits into from
Jul 17, 2018
Merged

Add DomainInternal to status for Route and Service #1586

merged 9 commits into from
Jul 17, 2018

Commits on Jul 15, 2018

  1. Add ServiceName to status for resources that create services 

    For resoruces that own a core Kubernetes Services, the name of the
service should be exposed on the resoruce's status. The Revision
resources already exposes `.status.serviceName`, this PR adds the same
property for the Route and Knative Service resources.

Yes, it's a bit strange to have a Serivce include the Service name in
it's status, ¯\_(ツ)_/¯

Fixes: #1584
    @scothis
    scothis committed Jul 15, 2018
    Configuration menu
    Copy the full SHA
    3029a48 View commit details
    Browse the repository at this point in the history

  2. Review feedback 

    - typos
- added status property to spec.md
    @scothis
    scothis committed Jul 15, 2018
    Configuration menu
    Copy the full SHA
    ef5d583 View commit details
    Browse the repository at this point in the history

  3. Add conformance tests

    @scothis
    scothis committed Jul 15, 2018
    Configuration menu
    Copy the full SHA
    bc23435 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2018

  1. Add DomainInternal to status for Service, Route and Revision

    @scothis
    scothis committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    19e5aaf View commit details
    Browse the repository at this point in the history

  2. Drop ServiceName from Service and Route

    @scothis
    scothis committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    aa4ae46 View commit details
    Browse the repository at this point in the history

  3. Update resource spec

    @scothis
    scothis committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    4fa9d06 View commit details
    Browse the repository at this point in the history

  4. Remove DomainInternal from Revision

    @scothis
    scothis committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    3be8173 View commit details
    Browse the repository at this point in the history

  5. dead code

    @scothis
    scothis committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    c37655b View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2018

  1. Update conformance test with TODOs

    @scothis
    scothis committed Jul 17, 2018
    Configuration menu
    Copy the full SHA
    80d5f73 View commit details
    Browse the repository at this point in the history