-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all usages of deprecated wait.PollImmediate with wait.PollUntilContextTimeout #15067
Replace all usages of deprecated wait.PollImmediate with wait.PollUntilContextTimeout #15067
Conversation
…ilContextTimeout Signed-off-by: Prashant Rewar <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: prashantrewar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @prashantrewar! It looks like this is your first PR to knative/serving 🎉 |
Hi @prashantrewar. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hi @prashantrewar these changes need to happen at the https://github.com/knative/pkg side. |
Also https://github.com/knative/networking Once those repos are updated we have automation to pull in the changes. |
Note the |
Hey @skonto and @dprotaso, I create a PR in https://github.com/knative/pkg. Please take a look. |
Hey @dprotaso and @skonto, I created a PR in https://github.com/knative/networking also. Please take a look. |
Fixes #14692
Proposed Changes
Release Note