[main] Upgrade to latest dependencies #14588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-automation
force-pushed
the
auto-updates/update-deps-main
branch
from
03aff48
to
a31f2ff
Compare
knative-prow
bot
added
the
size/M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14588 +/- ##
==========================================
- Coverage 86.01% 85.99% -0.03%
==========================================
Files 197 197
Lines 14916 14916
==========================================
- Hits 12830 12827 -3
- Misses 1775 1779 +4
+ Partials 311 310 -1 ☔ View full report in Codecov by Sentry. |
knative-prow
bot
added
lgtm
knative-automation
force-pushed
the
auto-updates/update-deps-main
branch
from
a31f2ff
to
4cf7241
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-automation, nak3, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-automation
force-pushed
the
auto-updates/update-deps-main
branch
from
4cf7241
to
5f467f7
Compare
|
New changes are detected. LGTM label has been removed. |
knative-automation
force-pushed
the
auto-updates/update-deps-main
branch
from
5f467f7
to
9dd357e
Compare
knative-prow
bot
added
area/networking
size/XXL
|
/retest |
|
There seems to be a difference in the behaviour of gorilla in the new version: |
bumping google.golang.org/api 5e4c19e...0d3b865: > 0d3b865 chore(main): release 0.149.0 (# 2230) > c84e6ff feat(all): auto-regenerate discovery clients (# 2242) > e5a53db chore(all): update all (# 2233) > 576f5e1 feat(all): auto-regenerate discovery clients (# 2241) > 3151bd7 feat(all): auto-regenerate discovery clients (# 2240) > cf09469 feat(all): auto-regenerate discovery clients (# 2239) > 8d66391 feat(all): auto-regenerate discovery clients (# 2238) > 3cc10bf feat(all): auto-regenerate discovery clients (# 2237) > da38ebd feat(all): auto-regenerate discovery clients (# 2236) > cc28ceb feat(all): auto-regenerate discovery clients (# 2235) > 8bb5867 feat(all): auto-regenerate discovery clients (# 2234) > a1fb230 feat(all): auto-regenerate discovery clients (# 2232) > 9835f38 feat(all): auto-regenerate discovery clients (# 2231) > 199783c feat(all): auto-regenerate discovery clients (# 2229) bumping knative.dev/hack d4af42e...0d99b7e: > 0d99b7e add function to set latest semver to latest (# 339) bumping knative.dev/networking 3bd0f7d...18529fd: > 18529fd upgrade to latest dependencies (# 888) bumping github.com/gorilla/websocket 9111bb8...ac0789b: > ac0789b update GitHub workflows (# 857) > 78c3487 update golang.org/x/net (# 856) > 666c197 Update go version & add verification/testing tools (# 840) > 8039329 Correct way to save memory using write buffer pool and freeing net.http default buffers (# 761) > 8983b96 Merge pull request # 839 from gorilla/coreydaley-patch-1 > 76ecc29 archive mode > 931041c Update README.md > af47554 check error before GotConn for trace > bc7ce89 Check for and report bad protocol in TLSClientConfig.NextProtos (# 788) > 27d91a9 drop the versions of go that are no longer supported + add 1.18 to ci > 78cf1bc Changed the method name UnderlyingConn to NetConn to align the methods names with Go 1.18 standard library (# 773) > 69d0eb9 Add check for Sec-WebSocket-Key header (# 752) bumping knative.dev/pkg a6c730f...acf0a2d: > acf0a2d Bump google.golang.org/api from 0.148.0 to 0.149.0 (# 2891) > 5e1261a Bump cloud.google.com/go/storage from 1.33.0 to 1.34.1 (# 2890) > 3b3f4e4 Bump github.com/gorilla/websocket from 1.5.0 to 1.5.1 (# 2889) > 8bf0f54 Bump golang.org/x/sync from 0.4.0 to 0.5.0 (# 2888) > fac3a4f fix closure variable in filtered factory (# 2884) bumping google.golang.org/genproto d307bd8...49dd2c1: > 49dd2c1 chore(all): update all (# 1067) > e917dd1 chore(deps): bump golang.org/x/net in /googleapis/api/servicecontrol (# 1063) > 8102cb6 chore(deps): bump golang.org/x/net in /googleapis/api/servicemanagement (# 1060) > baa7128 chore(deps): bump golang.org/x/net in /googleapis/api/apikeys (# 1062) > 67c69aa chore(deps): bump golang.org/x/net in /googleapis/bytestream (# 1061) > e298162 chore(deps): bump golang.org/x/net in /googleapis/api/serviceusage (# 1064) > 378ed82 chore(deps): bump golang.org/x/net in /googleapis/api (# 1065) > a6244dc chore(deps): bump golang.org/x/net from 0.14.0 to 0.17.0 (# 1066) > 8bfb1ae chore(all): update all (# 1059) > ceb4ed7 chore(all): auto-regenerate .pb.go files (# 1058) bumping google.golang.org/genproto/googleapis/rpc e917dd1...49dd2c1: > 49dd2c1 chore(all): update all (# 1067) bumping github.com/googleapis/enterprise-certificate-proxy a110527...d928958: > d928958 fix: Remove assertion for private key decryption support during pkcs11 init (# 109) > 5192b8e feat: Add KeyType API. (# 105) > bd11497 fix: Update windows github action to use go 1.20 (# 100) > 02fb4ca doc: More certificate config file path options (# 99) bumping google.golang.org/genproto/googleapis/api d307bd8...49dd2c1: > 49dd2c1 chore(all): update all (# 1067) > e917dd1 chore(deps): bump golang.org/x/net in /googleapis/api/servicecontrol (# 1063) > 8102cb6 chore(deps): bump golang.org/x/net in /googleapis/api/servicemanagement (# 1060) > baa7128 chore(deps): bump golang.org/x/net in /googleapis/api/apikeys (# 1062) > 67c69aa chore(deps): bump golang.org/x/net in /googleapis/bytestream (# 1061) > e298162 chore(deps): bump golang.org/x/net in /googleapis/api/serviceusage (# 1064) > 378ed82 chore(deps): bump golang.org/x/net in /googleapis/api (# 1065) > a6244dc chore(deps): bump golang.org/x/net from 0.14.0 to 0.17.0 (# 1066) > 8bfb1ae chore(all): update all (# 1059) > ceb4ed7 chore(all): auto-regenerate .pb.go files (# 1058) Signed-off-by: Knative Automation <[email protected]>
knative-automation
force-pushed
the
auto-updates/update-deps-main
branch
from
9dd357e
to
c300177
Compare
|
@knative-automation: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Yes, it seems I think we should fix upstream gorilla websocket but maybe we should pin to gorilla version to 1.15.0 in go.mod until we can fix it? |
Yes let's do that 👍 |
|
Thank you. I will do that soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cron -knative-prow-robot
/cc knative/serving-writers
/assign knative/serving-writers
Produced by: knative-extensions/knobots/actions/update-deps