Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fluentd config for ES backend #1247

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Fix fluentd config for ES backend #1247

merged 1 commit into from
Jun 18, 2018

Conversation

mdemirhan
Copy link
Contributor

Recent changes broke logging parsing for STDERR and STDOUT while trying to fix /var/log parsing. This change reverts that as stdout/err is more important scenario than /var/log and we will investigate /var/log issue separately.

Recent changes broke logging parsing for STDERR and STDOUT while trying to fix /var/log parsing. This change reverts that as stdout/err is more important scenario than /var/log and we will investigate /var/log issue separately.
@mdemirhan mdemirhan requested a review from yanweiguo June 18, 2018 16:30
@google-prow-robot google-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2018
@mdemirhan mdemirhan requested a review from tcnghia June 18, 2018 16:30
@tcnghia
Copy link
Contributor

tcnghia commented Jun 18, 2018

/approve
/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2018
@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdemirhan, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot merged commit 2ba8e0c into knative:master Jun 18, 2018
@mdemirhan mdemirhan deleted the logfix branch June 18, 2018 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants