-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This adds LastTransitionTime to all knative/serving resources. #1142
This adds LastTransitionTime to all knative/serving resources. #1142
Conversation
WIP until baseline changes go through. |
The following is the coverage report on pkg/. Say
*TestCoverage feature is being tested, do not rely on any info here yet |
This is automatically populated by `setCondition`. Other misc changes: * Switch `route_test.go` to us compact array syntax. * Switch `route_test.go` to the same pattern for checking conditions as used by the other controller tests. Fixes: knative/serving#1141
2dd5350
to
0c1a2b1
Compare
The following is the coverage report on pkg/. Say
*TestCoverage feature is being tested, do not rely on any info here yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, tcnghia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -94,6 +95,9 @@ type RouteCondition struct { | |||
|
|||
Status corev1.ConditionStatus `json:"status" description:"status of the condition, one of True, False, Unknown"` | |||
|
|||
// +optional | |||
LastTransitionTime metav1.Time `json:"lastTransitionTime,omitempty" description:"last time the condition transit from one status to another"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: "transited"? "transitioned"?
@@ -81,6 +82,9 @@ type ServiceCondition struct { | |||
|
|||
Status corev1.ConditionStatus `json:"status" description:"status of the condition, one of True, False, Unknown"` | |||
|
|||
// +optional | |||
LastTransitionTime metav1.Time `json:"lastTransitionTime,omitempty" description:"last time the condition transit from one status to another"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same transit
nit
This field was added in #1142 but missed the codegen step.
…native#1142) * Require 32 consecutive OK responses before having the endpoint ready * The point is that we do not add the RouteInconsistencyRetryChecker to the general Poll function but only to Check function which is used in CheckEndpointState. So tests that directly call client.Do should not be sending many requests. * Separate simple and robust retry checker * Use the multi/robust checker in CheckEndpointState * Use the simple checker in simple client.Do/Poll calls
This is automatically populated by
setCondition
.Other misc changes:
route_test.go
to us compact array syntax.route_test.go
to the same pattern for checking conditions as used by the other controller tests.Fixes: #1141