Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace log with glog for all tests #1104

Merged
merged 5 commits into from
Jun 11, 2018
Merged

replace log with glog for all tests #1104

merged 5 commits into from
Jun 11, 2018

Conversation

jessiezcc
Copy link
Contributor

Fixes #1066, #763

  • replace log with glog for all tests
  • update document with glog instructions

@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jessiezcc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2018
@jessiezcc jessiezcc requested a review from bobcatfish June 8, 2018 01:57
@google-prow-robot google-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 8, 2018
@dprotaso
Copy link
Member

dprotaso commented Jun 8, 2018

I'd like to be consistent and use the same logger within the whole project/repo. Thus not use glog but zap

These PRs is where the work was done for the controllers:
#998
#978
#933
#888

thoughts?

@jessiezcc
Copy link
Contributor Author

jessiezcc commented Jun 8, 2018

@dprotaso, we are leveraging glog VLog for verbose logs, and also get underlying k8s V logs for free, does zap have similar capability?
Also chatted with Mustafa (mdemirhan@), sounds like with zap, there is also extra work for log readability, and we still need glog to get k8s outputs, so I think glog alone should satisfy our test log need for now.

@jessiezcc
Copy link
Contributor Author

Actually, I'm opening a separate issue to track further about how test log can leverage zap structured log for better failure troubleshooting. Mustafa listed a few goodness of structured log that's beneficial for test failure diagnose. Would like to get this one in first though.

@mattmoor
Copy link
Member

Havent cracked the diff here, but generally I share @dprotaso's sentiment. We decided to go with zap, so let's go with zap.

@jessiezcc
Copy link
Contributor Author

I've created #1117 to track using zap in test log. My plan is to get this one merged first. Also it will take more than a week for me to get zap change in as I will be away at summit for almost a week (coming week). Let me know if you have string objections on having this PR merged, @mattmoor @dprotaso .

@adrcunha
Copy link
Contributor

/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2018
@adrcunha
Copy link
Contributor

/test pull-knative-serving-integration-tests

@google-prow-robot google-prow-robot merged commit e1b3aae into knative:master Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants