-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace log with glog for all tests #1104
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jessiezcc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dprotaso, we are leveraging glog VLog for verbose logs, and also get underlying k8s V logs for free, does zap have similar capability? |
Actually, I'm opening a separate issue to track further about how test log can leverage zap structured log for better failure troubleshooting. Mustafa listed a few goodness of structured log that's beneficial for test failure diagnose. Would like to get this one in first though. |
Havent cracked the diff here, but generally I share @dprotaso's sentiment. We decided to go with zap, so let's go with zap. |
I've created #1117 to track using zap in test log. My plan is to get this one merged first. Also it will take more than a week for me to get zap change in as I will be away at summit for almost a week (coming week). Let me know if you have string objections on having this PR merged, @mattmoor @dprotaso . |
/lgtm |
/test pull-knative-serving-integration-tests |
Fixes #1066, #763