Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken symlinks under /vendor. #2778

Closed
erain opened this issue Dec 21, 2018 · 3 comments
Closed

Broken symlinks under /vendor. #2778

erain opened this issue Dec 21, 2018 · 3 comments
Labels
area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/bug Categorizes issue or PR as related to a bug. kind/question Further information is requested

Comments

@erain
Copy link
Contributor

erain commented Dec 21, 2018

Expected Behavior

No broken symlinks in the repository.

Actual Behavior

There are multiple broken symlinks in the repository. Examples:

  1. https://github.com/knative/serving/tree/master/vendor/github.com/google/go-containerregistry/cmd/ko/test/kodata
  2. https://github.com/knative/serving/blob/master/vendor/github.com/prometheus/procfs/fixtures/26231/ns/mnt

Additional Info

I tried to use GCB to automatic build / release this repo, however noticed this issue and would like to know why.
@knative-prow-robot knative-prow-robot added area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/question Further information is requested kind/bug Categorizes issue or PR as related to a bug. labels Dec 21, 2018
@mattmoor
Copy link
Member

mattmoor commented Jan 3, 2019

cc @imjasonh @jonjohnsonjr

@jonjohnsonjr
Copy link
Contributor

We probably want to add something similar to this to update-deps.sh: https://github.com/google/go-containerregistry/blob/ed4be12360d0a967907a25201322302a10fb76b6/scripts/update-deps.sh#L28-L30

erain added a commit to erain/knative-serving that referenced this issue Jan 3, 2019
@erain
remove broken symlinks when updating deps
42391c9 
fix: knative#2778
Change-Id: Id249c00fa8a506fbbd1d21956b8bfd62c12a9958
@erain erain mentioned this issue Jan 3, 2019
Merged
@erain
Copy link
Contributor Author

erain commented Jan 3, 2019

Thanks @jonjohnsonjr for the info!

I sent PR #2842 . However when I actually executed ./hack/update-deps.sh I got some errors... Will learn some dep and get those broken symlinks removed in the same PR in a second commit as well.

erain added a commit to erain/knative-serving that referenced this issue Jan 7, 2019
@erain
remove broken symlinks when updating deps
7f3bbf0 
fix: knative#2778
Change-Id: Id249c00fa8a506fbbd1d21956b8bfd62c12a9958
knative-prow-robot pushed a commit that referenced this issue Jan 14, 2019
@erain @knative-prow-robot
Remove broken symlinks when updating deps (#2842)
9a74c67 
* remove broken symlinks when updating deps

fix: #2778
Change-Id: Id249c00fa8a506fbbd1d21956b8bfd62c12a9958

* Remove invalid symlinks by running update-deps.sh

* run update-codegen.sh as well
run update-codegen.sh as well
run update-codegen.sh as well
run update-codegen.sh as well
run update-codegen.sh as well
run update-codegen.sh as well
run update-codegen.sh as well
run update-codegen.sh as well
run update-codegen.sh as well

* manually delete vendor/github.com/prometheus/procfs/fixtures/26231/exe

...it is a symlink to /usr/bin/vim ...

* improve on deleting invalid symlinks

* fix typo and minor improvement to make it work on mac/linux

* take reviewer's approach for symlink cleanup

* remove verbose logging msg

* resolve reviewer's comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/bug Categorizes issue or PR as related to a bug. kind/question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@erain @mattmoor @jonjohnsonjr @knative-prow-robot