Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to configure the ELB Service to use with knative-sharedgateway #1890

Closed
tcnghia opened this issue Aug 20, 2018 · 3 comments
Closed
Assignees
Labels
area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features

Comments

@tcnghia
Copy link
Contributor

tcnghia commented Aug 20, 2018

Expected Behavior

Users should be able to choose which ELB Service that the Gateway knative-sharedgateway uses. This should default to the Istio's istio-ingressgateway Service. Together with that we should point users to instruction of how to add a new ELB and use it, in case they want to reserve istio-ingressgateway for something else.

That we can stay out of the business of creating the ELB knative-ingressgateway in the Istio namespace, which is very much a leak of abstraction barrier.

Actual Behavior

We default to use the knative-ingressgateway.

Steps to Reproduce the Problem

Additional Info

@knative-prow-robot
Copy link
Contributor

@tcnghia: GitHub didn't allow me to assign the following users: nghia.

Note that only knative members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

Expected Behavior

Users should be able to choose which ELB Service that the Gateway knative-sharedgateway uses. This should default to the Istio's istio-ingressgateway Service. Together with that we should point users to instruction of how to add a new ELB and use it, in case they want to reserve istio-ingressgateway for something else.

That we can stay out of the business of creating the ELB knative-ingressgateway in the Istio namespace, which is very much a leak of abstraction barrier.

Actual Behavior

We default to use the knative-ingressgateway.

Steps to Reproduce the Problem

Additional Info

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tcnghia
Copy link
Contributor Author

tcnghia commented Aug 20, 2018

/assign tcnghia

@tcnghia
Copy link
Contributor Author

tcnghia commented Nov 6, 2018

duplicate of #1969

@tcnghia tcnghia closed this as completed Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features
Projects
None yet
Development

No branches or pull requests

2 participants