Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Service Status testing #1224

Closed
mattmoor opened this issue Jun 15, 2018 · 1 comment
Closed

More Service Status testing #1224

mattmoor opened this issue Jun 15, 2018 · 1 comment
Assignees
Labels
area/API API objects and controllers kind/feature Well-understood/specified features, ready for coding.

Comments

@mattmoor
Copy link
Member

@dprotaso enumerated a lot of good tests here


I would suggest more granularity and test the scenarios below. Let me know if it's too pedantic. I'm suggesting this because there's no test for when a configuration fails and recovers. And there's some overlap testing the route failure flow in TestTypicalServiceFlow and TestRouteFailurePropagation

Each bullet point would be a scenario to test given the conditions when ...

service happy flow

when the service ready condition is unknown

  • route ready condition becomes true
  • configuration ready condition becomes true
  • both route and configuration ready condition becomes true

failure propagation

when the service ready condition is true
and both route & configuration ready conditions are true

  • route ready condition becomes false
  • configuration ready condition becomes false

configuration recovery

when the service ready condition is false
and route ready condition is true
and configuration ready condition is false

  • configuration ready condition becomes true

route recovery

when the service ready condition is false
and route ready condition is false
and configuration ready condition is true

  • route ready condition becomes true
@google-prow-robot google-prow-robot added area/API API objects and controllers kind/feature Well-understood/specified features, ready for coding. labels Jun 15, 2018
@dprotaso
Copy link
Member

dprotaso commented Jun 15, 2018

More test cases from here: #1222

unknown propagation

when the service ready condition is true
and both route & configuration ready conditions are true

  • route ready condition becomes unknow
  • configuration ready condition becomes unknown

jonjohnsonjr referenced this issue in jonjohnsonjr/elafros Jul 19, 2018
Fixes #1224

This breaks out recovery from the TypicalServiceFlow into the happy
path, route recovery, and configuration recovery.
jonjohnsonjr referenced this issue in jonjohnsonjr/elafros Jul 19, 2018
This breaks out recovery from the TypicalServiceFlow into the happy
path, route recovery, and configuration recovery.

Fixes #1224
google-prow-robot pushed a commit that referenced this issue Jul 25, 2018
* Add more service status propagation tests

This breaks out recovery from the TypicalServiceFlow into the happy
path, route recovery, and configuration recovery.

Fixes #1224

* Add failure recovery for route and config

Since they are likely to fail together, we test that we can recover from
both route and config failing then becoming ready.
ZhiminXiang pushed a commit to ZhiminXiang/serving-1 that referenced this issue Aug 2, 2018
* Add more service status propagation tests

This breaks out recovery from the TypicalServiceFlow into the happy
path, route recovery, and configuration recovery.

Fixes knative#1224

* Add failure recovery for route and config

Since they are likely to fail together, we test that we can recover from
both route and config failing then becoming ready.
nak3 added a commit to nak3/serving that referenced this issue Sep 2, 2022
* Add a target to enable internal-tls in Makefile

* Update CI template for internal-tls enabled
mgencur pushed a commit to mgencur/serving-1 that referenced this issue Sep 6, 2022
* Add a target to enable internal-tls in Makefile

* Update CI template for internal-tls enabled
mgencur pushed a commit to mgencur/serving-1 that referenced this issue Sep 6, 2022
* Add a target to enable internal-tls in Makefile

* Update CI template for internal-tls enabled
mgencur pushed a commit to mgencur/serving-1 that referenced this issue Sep 6, 2022
* Add a target to enable internal-tls in Makefile

* Update CI template for internal-tls enabled
nak3 added a commit to nak3/serving that referenced this issue Sep 7, 2022
* Add a target to enable internal-tls in Makefile

* Update CI template for internal-tls enabled
nak3 added a commit to nak3/serving that referenced this issue Sep 8, 2022
* Add a target to enable internal-tls in Makefile

* Update CI template for internal-tls enabled
skonto pushed a commit to skonto/serving that referenced this issue Sep 21, 2022
…ically (knative#1236)

* [RELEASE-v1.5] Add manifest patch for internal-tls to `openshift/release/artifacts` (knative#1202)

* Add secret to 1.5 CI yaml

* auto generated

* Support config to deploy internal certificates automatically (knative#13005)

* Add certificate reconciler for internal certs

* Fix cert path

* Temporary use local networking repo

* Support internal-encryption configuration

* Use const for cert name

* Fix lint

* rm blank line

* Drop unused variable

* Use one line style

* Use one line code

* Update net-kourier nightly

bumping knative.dev/net-kourier d758682...b9b1e8b:
  > b9b1e8b Use `internal-encryption` to deploy internal certificates automatically (# 855)
  > 427434c bump kind and k8s versions in kind-e2e tests (# 859)

Signed-off-by: Knative Automation <[email protected]>

* Verify SecretPKKey as well

* Do not drop activator always in the path

* Comment about ctrl-ca suffix

Co-authored-by: Knative Automation <[email protected]>

* Update deps

* Enable internal-tls on ocp-tls (knative#1203)

* Enable internal-tls on OCP 4.8

* Use tls to match JOB name

* Add a target to enable internal-tls in Makefile (knative#1224)

* Add a target to enable internal-tls in Makefile

* Update CI template for internal-tls enabled

* Tests for encryption with Kourier local gateway (knative#13263)

* Generate Secrets

* Commit generated cert-secret.yaml

* httpproxy enables tls client

* httpproxy uses https when CA_CERT specified

* Pass CA_CERT and SERVER_NAME env variables properly to tests

* Avoid using cluster-local certificates for external services

* Enable tls tests for cluster-local Kourier gateway

* Need to create test resources including the test namespace first
before installing Knative so that applying
test/config/tls/cert-secret.yaml succeeds

* TMP: Enable tls in the standard e2e make target - test purposes

* Use knative-serving-ingress ns for deploying server-certs

* Deploy certificates at test phase

* Separate test and install of installing certs

* Wait for knative-serving-ingress to exist

* Revert "TMP: Enable tls in the standard e2e make target - test purposes"

This reverts commit 5bb3549.

Co-authored-by: Kenjiro Nakayama <[email protected]>
Co-authored-by: Knative Automation <[email protected]>
mgencur added a commit to openshift-knative/serving that referenced this issue Oct 12, 2022
…ve#1235)

* Enable internal-tls on ocp-tls (knative#1203)

* Enable internal-tls on OCP 4.8

* Use tls to match JOB name

* Add a target to enable internal-tls in Makefile (knative#1224)

* Add a target to enable internal-tls in Makefile

* Update CI template for internal-tls enabled

* Tests for encryption with Kourier local gateway (knative#13263)

* Generate Secrets

* Commit generated cert-secret.yaml

* httpproxy enables tls client

* httpproxy uses https when CA_CERT specified

* Pass CA_CERT and SERVER_NAME env variables properly to tests

* Avoid using cluster-local certificates for external services

* Enable tls tests for cluster-local Kourier gateway

* Need to create test resources including the test namespace first
before installing Knative so that applying
test/config/tls/cert-secret.yaml succeeds

* TMP: Enable tls in the standard e2e make target - test purposes

* Fix indentation

* Use knative-serving-ingress ns for deploying server-certs

* Deploy certificates at test phase

* Separate test and install of installing certs

* Wait for knative-serving-ingress to exist

* Revert "TMP: Enable tls in the standard e2e make target - test purposes"

This reverts commit 54fabb3.

Co-authored-by: Kenjiro Nakayama <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API API objects and controllers kind/feature Well-understood/specified features, ready for coding.
Projects
None yet
Development

No branches or pull requests

4 participants