Skip to content

Commit

Permalink
Retired serving state is not set anywhere (#1204)
Browse files Browse the repository at this point in the history
  • Loading branch information
glyn authored and google-prow-robot committed Jun 15, 2018
1 parent cca9a05 commit 29dadab
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions docs/scaling/DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ In the Reserve state, the Revision has no scheduled Pods and consumes no CPU. T

In the Retired state, the Revision has provisioned resources. No requests will be served for the Revision.

Note: Retired state is currently not set anywhere. See [issue 1203](https://github.com/knative/serving/issues/1203).

## Context

```
Expand Down
1 change: 1 addition & 0 deletions pkg/apis/serving/v1alpha1/revision_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ const (
// anymore. It should not have any Istio routes or Kubernetes resources.
// A Revision may be brought out of retirement, but it may take longer than
// it would from a "Reserve" state.
// Note: currently not set anywhere. See https://github.com/knative/serving/issues/1203
RevisionServingStateRetired RevisionServingStateType = "Retired"
)

Expand Down

0 comments on commit 29dadab

Please sign in to comment.