Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Webhook to ed25519 and expiration of the certificate to seven days #1998

Merged
merged 3 commits into from
Jan 22, 2021

Conversation

Harwayne
Copy link
Contributor

Changes

  • 🧹 Webhook uses ed25519 rather than RSA 2048.
  • 🧹 Change the expiration of the certificate to seven days and the recreation time to one day before expiration.

/kind enhancement

Release Note

NONE

Docs


@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 22, 2021
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 22, 2021
@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #1998 (fcb4b4a) into master (32a3248) will decrease coverage by 0.04%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1998      +/-   ##
==========================================
- Coverage   67.29%   67.25%   -0.05%     
==========================================
  Files         214      214              
  Lines        9061     9065       +4     
==========================================
- Hits         6098     6097       -1     
- Misses       2693     2696       +3     
- Partials      270      272       +2     
Impacted Files Coverage Δ
webhook/certificates/certificates.go 69.69% <0.00%> (ø)
webhook/certificates/resources/certs.go 60.71% <72.72%> (-1.79%) ⬇️
webhook/certificates/resources/secret.go 85.71% <100.00%> (ø)
test/gcs/mock/mock.go 91.39% <0.00%> (-1.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a3248...c9d1c4d. Read the comment docs.

Copy link
Member

@dprotaso dprotaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @markusthoemmes @julz are security focused folks

webhook/certificates/certificates_test.go Outdated Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2021
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants