Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Audience field in duckv1.Addressable #2795

Closed
creydr opened this issue Aug 15, 2023 · 4 comments · Fixed by #2798
Closed

Add Audience field in duckv1.Addressable #2795

creydr opened this issue Aug 15, 2023 · 4 comments · Fixed by #2798
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@creydr
Copy link
Member

creydr commented Aug 15, 2023

To allow Addressables to provide their Audience field, the duckv1.Addressable needs to be extended to include the Audience:

type Addressable struct {
    
    ...

	// Audience is the OIDC audience for this address.
	// +optional
	Audience *string `json:"audience,omitempty"`
}

Time Estimate (optional)

1

Additional context (optional)

/good-first-issue

@creydr creydr added the kind/TBD Parked issue that required triaging/revisit in a near future. label Aug 15, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 15, 2023

@creydr:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

To allow Addressables to provide their Audience field, the duckv1.Addressable needs to be extended to include the Audience:

type Addressable struct {
   
   ...

  // Audience is the OIDC audience for this address.
  // +optional
  Audience *string `json:"audience,omitempty"`
}

Time Estimate (optional)

1

Additional context (optional)

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 15, 2023
@creydr creydr moved this to 🆕 New in Eventing Sender Identity Aug 16, 2023
@creydr creydr removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 17, 2023
@creydr creydr moved this from 🆕 New to Draft in Eventing Sender Identity Aug 17, 2023
@creydr creydr added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed kind/TBD Parked issue that required triaging/revisit in a near future. labels Aug 17, 2023
@creydr creydr moved this from Draft to 📋 Backlog in Eventing Sender Identity Aug 17, 2023
@creydr creydr changed the title [DRAFT] Add Audience field in duckv1.Addressable Add Audience field in duckv1.Addressable Aug 17, 2023
@abhijeetgauravm
Copy link
Contributor

Can u assign me?

@creydr
Copy link
Member Author

creydr commented Aug 17, 2023

Can u assign me?

/assign @abhijeetgauravm

You can do this too by using /assign. You can also find the list of prow commands here: https://prow.knative.dev/command-help

@abhijeetgauravm
Copy link
Contributor

Can u assign me?

/assign @abhijeetgauravm

You can do this too by using /assign. You can also find the list of prow commands here: https://prow.knative.dev/command-help

okay sure @creydr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants