Added the kafka source 1.14 #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
houshengbo
commented
Apr 25, 2024
•
houshengbo
commented
- Added the kafka source 1.14 manifests.
- Added the RBAC missing for the kafka source 1.14.
knative-prow
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: houshengbo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1778 +/- ##
==========================================
+ Coverage 63.54% 66.21% +2.67%
==========================================
Files 53 53
Lines 2584 2081 -503
==========================================
- Hits 1642 1378 -264
+ Misses 827 588 -239
Partials 115 115 ☔ View full report in Codecov by Sentry. |
houshengbo
force-pushed
the
add-kafka-14
branch
from
581bb22 to
1a34a59
Compare
knative-prow
bot
added
size/XXL
houshengbo
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
houshengbo
force-pushed
the
add-kafka-14
branch
from
1a34a59 to
890738b
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.