-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove requestDelay flag for tests #972
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #972 +/- ##
==========================================
- Coverage 93.43% 93.41% -0.02%
==========================================
Files 36 36
Lines 1249 1003 -246
==========================================
- Hits 1167 937 -230
+ Misses 69 53 -16
Partials 13 13 ☔ View full report in Codecov by Sentry. |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrew-su, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dprotaso is it ok to cherrypick this one to release-1.14 as well? |
No - that'll create CI churn and there's no utility in merging it back since the behaviour is opt-in via a flag. Users can just not set the flag |
Changes
requestDelay
as this can cause dispatch test to run for an extremely long time./kind cleanup