Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requestDelay flag for tests #972

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

andrew-su
Copy link
Member

Changes

  • 🧹 Remove test flag requestDelay as this can cause dispatch test to run for an extremely long time.

/kind cleanup

@knative-prow knative-prow bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 19, 2024
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.41%. Comparing base (75762ca) to head (55a83da).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
- Coverage   93.43%   93.41%   -0.02%     
==========================================
  Files          36       36              
  Lines        1249     1003     -246     
==========================================
- Hits         1167      937     -230     
+ Misses         69       53      -16     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nader-ziada
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
@dprotaso
Copy link
Member

/lgtm
/approve

Copy link

knative-prow bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrew-su, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
@knative-prow knative-prow bot merged commit 9188dac into knative:main Apr 19, 2024
27 checks passed
@izabelacg
Copy link
Member

@dprotaso is it ok to cherrypick this one to release-1.14 as well?

@dprotaso
Copy link
Member

dprotaso commented Apr 19, 2024

No - that'll create CI churn and there's no utility in merging it back since the behaviour is opt-in via a flag. Users can just not set the flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants