-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop unused types #933
drop unused types #933
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #933 +/- ##
==========================================
- Coverage 24.03% 23.04% -1.00%
==========================================
Files 91 83 -8
Lines 5129 5063 -66
==========================================
- Hits 1233 1167 -66
Misses 3883 3883
Partials 13 13 ☔ View full report in Codecov by Sentry. |
codecov is broken in this repo |
/override codecov/project (see #934) |
@dprotaso: Overrode contexts on behalf of dprotaso: codecov/project In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @ReToCode @skonto |
/lgtm |
/hold for others to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is there are a way to achieve the same with the old design doc? |
/hold cancel
I think it would require some work on us to coordinate domain selection and gateway selection. This might be doable without CRDs and just operator knobs in our config maps - eg. see the istio gateway selection feature track |
These types were added to support a feature track defined here - https://docs.google.com/document/d/1kefwbDQ6qCsw-DbqmfpLlQfEvLtO85RgUlQMCqJnTLg/edit?resourcekey=0-lzesL79SETekPVyzEfc4Ww#heading=h.n8a530nnrb
This seems less relevant with Gateway API and the feature track has been abandoned for a few years