Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop unused types #933

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Feb 22, 2024

These types were added to support a feature track defined here - https://docs.google.com/document/d/1kefwbDQ6qCsw-DbqmfpLlQfEvLtO85RgUlQMCqJnTLg/edit?resourcekey=0-lzesL79SETekPVyzEfc4Ww#heading=h.n8a530nnrb

This seems less relevant with Gateway API and the feature track has been abandoned for a few years

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.04%. Comparing base (556d751) to head (02880c3).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #933      +/-   ##
==========================================
- Coverage   24.03%   23.04%   -1.00%     
==========================================
  Files          91       83       -8     
  Lines        5129     5063      -66     
==========================================
- Hits         1233     1167      -66     
  Misses       3883     3883              
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member Author

codecov is broken in this repo

@dprotaso
Copy link
Member Author

dprotaso commented Feb 22, 2024

/override codecov/project (see #934)

Copy link

knative-prow bot commented Feb 22, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: codecov/project

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member Author

/assign @ReToCode @skonto
/cc @izabelacg

@izabelacg
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2024
@dprotaso
Copy link
Member Author

dprotaso commented Feb 23, 2024

/hold for others to review

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2024
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

knative-prow bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skonto
Copy link
Contributor

skonto commented Feb 26, 2024

This seems less relevant with Gateway API

Is there are a way to achieve the same with the old design doc?

@dprotaso
Copy link
Member Author

/hold cancel

Is there are a way to achieve the same with the old design doc?

I think it would require some work on us to coordinate domain selection and gateway selection. This might be doable without CRDs and just operator knobs in our config maps - eg. see the istio gateway selection feature track

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2024
@knative-prow knative-prow bot merged commit 7391d20 into knative:main Feb 26, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants