Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Set latest release only when publishing to Github #346

Merged
merged 2 commits into from
Nov 9, 2023
Merged

🐛 Set latest release only when publishing to Github #346

merged 2 commits into from
Nov 9, 2023

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Nov 9, 2023

Changes

  • 🐛 Set latest release only when publishing to Github

/kind bug

Follow up #343
Fixes #342

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 9, 2023
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cardil cardil requested a review from krsna-m November 9, 2023 18:29
@knative-prow knative-prow bot requested a review from upodroid November 9, 2023 18:29
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 9, 2023
krsna-m
krsna-m reviewed Nov 9, 2023
View reviewed changes
release.sh Show resolved Hide resolved
krsna-m
krsna-m reviewed Nov 9, 2023
View reviewed changes
release.sh Outdated Show resolved Hide resolved
@cardil @krsna-m
Add explanation
4d05146 
Co-authored-by: kmahapatra <[email protected]>
@cardil cardil requested a review from krsna-m November 9, 2023 18:47
@krsna-m
Copy link
Contributor

krsna-m commented Nov 9, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Nov 9, 2023

/cherry-pick release-1.12

@knative-prow-robot
Copy link

@kvmware: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krsna-m
Copy link
Contributor

krsna-m commented Nov 9, 2023

/cherry-pick release-1.11

@knative-prow-robot
Copy link

@kvmware: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 5deadde into knative:main Nov 9, 2023
@knative-prow-robot
Copy link

@kvmware: new pull request created: #347

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Nov 9, 2023
Merged
Merged
@knative-prow-robot
Copy link

@kvmware: new pull request created: #348

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid Awaiting requested review from upodroid

@krsna-m krsna-m Awaiting requested review from krsna-m

Assignees

@krsna-m krsna-m

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set_latest_to_highest_semver func fails the nighly release jobs
3 participants
@cardil @krsna-m @knative-prow-robot