Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Remove deps from go.mod for knative.dev/hack #320

Merged
merged 2 commits into from
Sep 25, 2023
Merged

🐛 Remove deps from go.mod for knative.dev/hack #320

merged 2 commits into from
Sep 25, 2023

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Sep 22, 2023

Changes

  • 🐛 Remove deps from go.mod for knative.dev/hack

/kind bug

Fixes #318

@knative-prow
Copy link

knative-prow bot commented Sep 22, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 22, 2023
@knative-prow knative-prow bot requested review from krsna-m and upodroid September 22, 2023 17:08
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 22, 2023
@cardil cardil force-pushed the bugfix/no-deps branch 2 times, most recently from b99242b to 7b03947 Compare September 22, 2023 17:10
@krsna-m krsna-m requested a review from dprotaso September 22, 2023 17:12
@cardil
Copy link
Contributor Author

cardil commented Sep 22, 2023

/test all

@cardil
Copy link
Contributor Author

cardil commented Sep 25, 2023

/test all

@cardil cardil changed the title [WIP] 🐛 Remove deps from go.mod for knative.dev/hack 🐛 Remove deps from go.mod for knative.dev/hack Sep 25, 2023
@cardil cardil marked this pull request as ready for review September 25, 2023 11:14
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2023
@knative-prow knative-prow bot requested a review from psschwei September 25, 2023 11:14
upodroid
upodroid approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@knative-prow
Copy link

knative-prow bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2023
@knative-prow knative-prow bot merged commit 74aa02a into knative:main Sep 25, 2023
9 checks passed
@cardil cardil deleted the bugfix/no-deps branch September 25, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@krsna-m krsna-m Awaiting requested review from krsna-m

@dprotaso dprotaso Awaiting requested review from dprotaso

@psschwei psschwei Awaiting requested review from psschwei

Assignees

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The knative.dev/hack go package shouldn't contain any go deps
2 participants
@cardil @upodroid