Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eventing-crds.yaml and eventing-core.yaml for eventing setup #24

Merged

Conversation

navidshaikh
Copy link
Contributor

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 18, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 18, 2020
@navidshaikh
Copy link
Contributor Author

/cc @n3wscott @chizhg

@albertomilan
Copy link

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2020
@n3wscott
Copy link

/lgtm
/approve

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: albertomilan, n3wscott, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2020
@knative-prow-robot knative-prow-robot merged commit b31d3bb into knative:master Nov 18, 2020
@navidshaikh navidshaikh deleted the pr/fix-eventing-nightly branch November 18, 2020 19:30
navidshaikh added a commit to navidshaikh/hack that referenced this pull request Nov 19, 2020
knative-prow-robot pushed a commit that referenced this pull request Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants