Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing workspaces decl in the scaffold task #2587

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Nov 22, 2024

Changes

  • 🐛 Fix missing source workspaces declaration in the scaffold task. This led to TaskRun ending with TaskRunValidationFailed: workspace binding "source" does not match any declared workspace.
    This behaviour was observed by @alanreynosov on his k3s cluster, we have not seen it so far.

/kind bug

fix: workspace binding "source" does not match any declared workspace for scaffold task

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 22, 2024
@knative-prow knative-prow bot requested review from jrangelramos and rhuss November 22, 2024 19:01
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2024
@matejvasek matejvasek requested review from matzew, gauron99 and lkingland and removed request for rhuss and jrangelramos November 22, 2024 19:01
@matejvasek
Copy link
Contributor Author

cc @alanreynosov

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.40%. Comparing base (1dd2e43) to head (b06c028).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2587      +/-   ##
==========================================
+ Coverage   64.14%   65.40%   +1.25%     
==========================================
  Files         130      130              
  Lines       15513    15516       +3     
==========================================
+ Hits         9951    10148     +197     
+ Misses       4623     4392     -231     
- Partials      939      976      +37     
Flag Coverage Δ
e2e-test 35.82% <0.00%> (-0.01%) ⬇️
e2e-test-oncluster 32.91% <100.00%> (+0.08%) ⬆️
e2e-test-oncluster-runtime 28.66% <100.00%> (?)
e2e-test-runtime-python 25.85% <0.00%> (?)
e2e-test-runtime-quarkus 26.00% <0.00%> (?)
e2e-test-runtime-rust 24.93% <0.00%> (?)
e2e-test-runtime-springboot 24.99% <0.00%> (?)
e2e-test-runtime-typescript 25.96% <0.00%> (?)
integration-tests 51.95% <100.00%> (+2.26%) ⬆️
unit-tests 50.92% <100.00%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor Author

PTAL @lkingland @gauron99 @matzew

1 similar comment
@matejvasek
Copy link
Contributor Author

PTAL @lkingland @gauron99 @matzew

@lkingland
Copy link
Member

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2024
Copy link

knative-prow bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 8815c53 into knative:main Nov 28, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants