-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing workspaces decl in the scaffold task #2587
Conversation
Signed-off-by: Matej Vašek <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2587 +/- ##
==========================================
+ Coverage 64.14% 65.40% +1.25%
==========================================
Files 130 130
Lines 15513 15516 +3
==========================================
+ Hits 9951 10148 +197
+ Misses 4623 4392 -231
- Partials 939 976 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PTAL @lkingland @gauron99 @matzew |
1 similar comment
PTAL @lkingland @gauron99 @matzew |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
source
workspaces declaration in thescaffold
task. This led to TaskRun ending withTaskRunValidationFailed: workspace binding "source" does not match any declared workspace
.This behaviour was observed by @alanreynosov on his k3s cluster, we have not seen it so far.
/kind bug