feat: reconcile eventtype v1beta3 resources

[Cali0707]

Fixes #6754

This lets us reconcile eventtype v1beta3 resources with the updated eventtype v1beta3 logic.

Proposed Changes

• If no reference is set, reconcile to ready
• Reconcile on v1beta3 struct, not v1beta2

EventTypes no longer need a reference to be set on them

[Cali0707]

/cc @matzew

One thing I was realizing while working on this is that maybe for the "required" id/specversion attributes we should default them, especially in the case of the "id" where we just want to say that it will be there but it doesn't make sense to give it a specific value

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 67.82%. Comparing base (57b52ea) to head (574f73e).

Files	Patch %	Lines
pkg/reconciler/testing/v1/eventtype.go	80.00%	6 Missing and 3 partials ⚠️
pkg/apis/eventing/v1beta3/eventtype_lifecycle.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8087      +/-   ##
==========================================
+ Coverage   67.80%   67.82%   +0.02%     
==========================================
  Files         367      367              
  Lines       17373    17411      +38     
==========================================
+ Hits        11779    11809      +30     
- Misses       4859     4864       +5     
- Partials      735      738       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[matzew]

One thing I was realizing while working on this is that maybe for the "required" id/specversion attributes we should default them, especially in the case of the "id" where we just want to say that it will be there but it doesn't make sense to give it a specific value

type/source are also required.

I think we just need to make sure that they are around. Not sure on defaulting. One EventType describes a series of same/similar CloudEvents. It is not a 1-1 mapping. It is more a category, rather than a specific event

[matzew]

k get eventtypes.eventing.knative.dev
NAME                                  TYPE   SOURCE   REFERENCE NAME   REFERENCE KIND   DESCRIPTION   READY   REASON
dev.knative.source.github.push-v1b3                   default          Broker                         False   ResourceDoesNotExist

hrm...?

[Cali0707]

k get eventtypes.eventing.knative.dev
NAME                                  TYPE   SOURCE   REFERENCE NAME   REFERENCE KIND   DESCRIPTION   READY   REASON
dev.knative.source.github.push-v1b3                   default          Broker                         False   ResourceDoesNotExist

hrm...?

@matzew I think the problem is that my branch didn't have the fix for the default reference on it, if you try again now it should work, I get:

k get eventtypes
NAME                                  TYPE   SOURCE   REFERENCE NAME   REFERENCE KIND   DESCRIPTION   READY   REASON
dev.knative.source.github.push-v1b3                                                                   True    

[Cali0707]

/test reconciler-tests

[matzew]

also tried w/ the auto-create:

apiVersion: eventing.knative.dev/v1beta3
kind: EventType
metadata:
  annotations:
    eventing.knative.dev/creator: system:serviceaccount:knative-eventing:mt-broker-ingress
    eventing.knative.dev/lastModifier: system:serviceaccount:knative-eventing:mt-broker-ingress
  creationTimestamp: "2024-07-11T07:50:07Z"
  generation: 1
  name: et-default-3c4b2767ec442c946530776794ba99cb
  namespace: default
  ownerReferences:
  - apiVersion: eventing.knative.dev/v1
    kind: Broker
    name: default
    uid: 8abe927f-5876-4aac-a004-25d90c37a57f
  resourceVersion: "19273"
  uid: 5ca13b0b-cd5d-4597-85c5-04a06c1996c7
spec:
  attributes:
  - name: type
    required: true
    value: org.apache.matzew.superEvent
  - name: source
    required: true
    value: /some/source
  description: Event Type auto-created by controller
  reference:
    address: http
    apiVersion: eventing.knative.dev/v1
    kind: Broker
    name: default
    namespace: default
status:
  conditions:
  - lastTransitionTime: "2024-07-11T07:50:07Z"
    status: "True"
    type: Ready
  - lastTransitionTime: "2024-07-11T07:50:07Z"
    status: "True"
    type: ReferenceExists
  observedGeneration: 1

[matzew]

@Cali0707 for the CE id, specversion etc, we must add extra logic to capture this properly on the spec

[matzew]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Cali0707,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment