[release-1.13] Create SinkBindings token-secret only if sink has an audience set #7706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
size/M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.13 #7706 +/- ##
=============================================
Coverage 74.43% 74.43%
=============================================
Files 262 262
Lines 15058 15058
=============================================
Hits 11209 11209
Misses 3247 3247
Partials 602 602 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, knative-prow-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
creydr
added a commit
to creydr/knative-eventing
that referenced
this pull request
Feb 20, 2024
…udience set (knative#7706) * Create SinkBindings token-secret only if sink has audience set. * Run goimports --------- Co-authored-by: Christoph Stäbler <[email protected]>
creydr
added a commit
to creydr/knative-eventing
that referenced
this pull request
Feb 20, 2024
…udience set (knative#7706) * Create SinkBindings token-secret only if sink has audience set. * Run goimports --------- Co-authored-by: Christoph Stäbler <[email protected]>
openshift-merge-bot bot
pushed a commit
to openshift-knative/eventing
that referenced
this pull request
Feb 20, 2024
…udience set (knative#7706) (#539) * Create SinkBindings token-secret only if sink has audience set. * Run goimports --------- Co-authored-by: Knative Prow Robot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #7703