New Event Filtering: Add rekt test to verify that empty filters does not override filter

[pawarpranav83]

Fixes #7298

Proposed Changes

• Added one feature function for subscriptionAPI filters overriding filter attribute logic
• Added one feature function for filter attributes working when subscriptionAPI filters field is empty.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: pawarpranav83 / name: Pranav (fdf30ec, c8badaf)
• ✅ login: Cali0707 / name: Calum Murray (c8badaf)

[knative-prow]

Welcome @pawarpranav83! It looks like this is your first PR to knative/eventing 🎉

[knative-prow]

Hi @pawarpranav83. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pawarpranav83]

Hey @Cali0707, I also added a feature function for the multiple filters for one trigger (it was assigned three months ago, I hope it's alright to make changes for that issue).
Also, should we add a multiple filters unit test in filter_handler_test.go?

[Cali0707]

Hey @Cali0707, I also added a feature function for the multiple filters for one trigger (it was assigned three months ago, I hope it's alright to make changes for that issue).

Yeah feel free to work on that if no progress has been made there for a while, just leave a comment on the issue saying you're working on it now.

I would prefer if the changes for the two issues were in two separate PRs, if possible.

[pawarpranav83]

Any additional changes?

[Cali0707]

/ok-to-test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (57901b9) 75.55% compared to head (c8badaf) 74.56%.
Report is 13 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7534      +/-   ##
==========================================
- Coverage   75.55%   74.56%   -1.00%     
==========================================
  Files         261      262       +1     
  Lines       14668    14951     +283     
==========================================
+ Hits        11083    11148      +65     
- Misses       3006     3215     +209     
- Partials      579      588       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pawarpranav83]

Only FiltersOverrideAttributeFilterFeature is covered in the 1.29 rekt test, and it timed out before FilterAttributeWithEmptyFiltersFeature could even start but the second feature was covered in the 1.27 rekt test, and the first one wasn't :), what do we do?

Can't we extend the time-out period? cause in other PRs these tests are failing too.

[Cali0707]

They all run in reconciler-tests_eventing_main, so it isn't too much of a concern if one of the GH Actions timed out. We can retest the prow job to make sure everything is working with these changes.

/retest-required

[pawarpranav83]

Can you provide tide test approval if there aren't any additional changes to be done? @Cali0707

[pawarpranav83]

Accidentally closed the PR while updating another branch.

/reopen

[knative-prow]

@pawarpranav83: Failed to re-open PR: state cannot be changed. There are no new commits on the pawarpranav83:main branch.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Cali0707]

Just a few nits on this, otherwise it is generally looking good so far

[pawarpranav83]

/retest-required

[pawarpranav83]

/test reconciler-tests

[pawarpranav83]

@Leo6Leo can u approve the changes as well if there aren't any more changes to be done?

[Cali0707]

/lgtm
/approve

Thanks @pawarpranav83, this is great!

FYI, if you want another review from someone after they gave an initial review and you've made some changes, the easiest way is to /cc them - our bot will pick up on that and re-request their review. For more info on how this works, feel free to check out https://knative.dev/blog/articles/getting-started-blog-p2/#interacting-with-prow

[Leo6Leo]

Hey @pawarpranav83, thanks for the great work! this is great to me as well. LGTM

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, Leo6Leo, pawarpranav83

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/OWNERS [Cali0707,Leo6Leo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Cali0707]

/retest-required

[Cali0707]

/retest-required

[pawarpranav83]

/retest-required