Add marker for Trigger to mark OIDCIdentity condition as not supported
#7316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
size/S
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7316 +/- ##
=======================================
Coverage 77.54% 77.55%
=======================================
Files 250 250
Lines 13529 13533 +4
=======================================
+ Hits 10491 10495 +4
Misses 2514 2514
Partials 524 524
☔ View full report in Codecov by Sentry. |
pierDipi
reviewed
Sep 28, 2023
|
/retest |
|
/cc @pierDipi |
This was referenced Sep 29, 2023
Closed
Closed
Closed
Closed
|
@pierDipi could you recheck? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
In #7299 we introduced a new Trigger condition type (
OIDCIdentityCreated) to mark if the Triggers OIDC identity was created successfully.Anyhow not all broker classes support the OIDC authentication yet and mark their Triggers
OIDCIdentityCreatedas true as they either created the identity or didn't create it as the feature is disabled.These broker classes could mark their Triggers
OIDCIdentityCreatedcondition as ready, but with the message "OIDC feature not supported yet".This PR addresses it and adds helper methods to set the condition accordingly.