-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose a Brokers audience in its status #7237
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7237 +/- ##
==========================================
+ Coverage 77.73% 77.75% +0.02%
==========================================
Files 246 247 +1
Lines 13284 13298 +14
==========================================
+ Hits 10326 10340 +14
Misses 2435 2435
Partials 523 523
☔ View full report in Codecov by Sentry. |
44e21c9
to
ecfb418
Compare
ecfb418
to
6eaecce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @creydr |
/retest |
Fixes #7184
Proposed Changes
Pre-review Checklist
Hints:
auth.GetAudience()
should have only accepted akmeta.Accessor
(includesmetav1.TypeMeta
andmetav1.ObjectMeta
), to construct the audience string. Anyhowbroker.ReconcileKind()
does not always get a broker object with provisionedTypeMeta
, so I had to pass theGroup
andKind
directly.Release Note