Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a Brokers audience in its status #7237

Merged
merged 5 commits into from
Sep 11, 2023

Conversation

creydr
Copy link
Member

@creydr creydr commented Sep 7, 2023

Fixes #7184

Proposed Changes

  • 🎁 Expose audience in Broker status

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Hints:

  • Actually auth.GetAudience() should have only accepted a kmeta.Accessor (includes metav1.TypeMeta and metav1.ObjectMeta), to construct the audience string. Anyhow broker.ReconcileKind() does not always get a broker object with provisioned TypeMeta, so I had to pass the Group and Kind directly.

Release Note

Expose OIDC audience of a Broker in its status

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 7, 2023
@knative-prow knative-prow bot requested review from aliok and mgencur September 7, 2023 09:02
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (7876f12) 77.73% compared to head (6eaecce) 77.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7237      +/-   ##
==========================================
+ Coverage   77.73%   77.75%   +0.02%     
==========================================
  Files         246      247       +1     
  Lines       13284    13298      +14     
==========================================
+ Hits        10326    10340      +14     
  Misses       2435     2435              
  Partials      523      523              
Files Changed Coverage Δ
pkg/apis/eventing/v1/broker_lifecycle.go 100.00% <100.00%> (ø)
pkg/apis/eventing/v1/test_helper.go 92.68% <100.00%> (+0.37%) ⬆️
pkg/auth/audience.go 100.00% <100.00%> (ø)
pkg/reconciler/broker/broker.go 77.89% <100.00%> (+0.61%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr creydr force-pushed the expose-audience-in-broker branch from 44e21c9 to ecfb418 Compare September 7, 2023 11:27
@creydr creydr force-pushed the expose-audience-in-broker branch from ecfb418 to 6eaecce Compare September 11, 2023 07:40
@creydr creydr changed the title [WIP] Expose a Brokers audience in its status Expose a Brokers audience in its status Sep 11, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2023
@creydr
Copy link
Member Author

creydr commented Sep 11, 2023

Rebased after #7189 merged

/assign @pierDipi

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member

Thanks @creydr

@creydr
Copy link
Member Author

creydr commented Sep 11, 2023

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support exposing the Audience of a Broker
2 participants