Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.16] backport 4168 to .16 #4225

Merged
merged 1 commit into from
Oct 6, 2020
Merged

[0.16] backport 4168 to .16 #4225

merged 1 commit into from
Oct 6, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Oct 6, 2020

Fixes #4165

Proposed Changes

Release Note

- 🐛 Fix bug
Backport #4168 which fixed #4165

Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 6, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 6, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2020
@vaikas vaikas changed the title backport 4168 to .16 [0.16] backport 4168 to .16 Oct 6, 2020
pierDipi
pierDipi approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member

matzew commented Oct 6, 2020

/refresh
/test all

@pierDipi
Copy link
Member

pierDipi commented Oct 6, 2020

/check-cla

@vaikas
Copy link
Contributor Author

vaikas commented Oct 6, 2020

/rescan cla
/rescan

@vaikas
Copy link
Contributor Author

vaikas commented Oct 6, 2020

/googlebot rescan

@pierDipi
Copy link
Member

pierDipi commented Oct 6, 2020

@googlebot rescan

@knative-prow-robot knative-prow-robot merged commit 7d93326 into knative:release-0.16 Oct 6, 2020
@vaikas vaikas deleted the backport-4168-16 branch October 6, 2020 13:02
@vaikas
Copy link
Contributor Author

vaikas commented Oct 6, 2020

Thanks @pierDipi and @matzew for shepherding this through :) LOL :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@Harwayne Harwayne Awaiting requested review from Harwayne

@n3wscott n3wscott Awaiting requested review from n3wscott

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vaikas @knative-prow-robot @matzew @pierDipi @googlebot