-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix metrics port mismatch between svc and deployment in broker manifests #4107
Fix metrics port mismatch between svc and deployment in broker manifests #4107
Conversation
- containerPort: 9090 | ||
- containerPort: 9092 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corresponding Service:
eventing/config/brokers/mt-channel-broker/deployments/broker-filter.yaml
Lines 98 to 106 in 036711d
ports: | |
- name: http | |
port: 80 | |
protocol: TCP | |
targetPort: 8080 | |
- name: http-metrics | |
port: 9092 | |
protocol: TCP | |
targetPort: 9092 |
- containerPort: 9090 | ||
- containerPort: 9092 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corresponding Service:
eventing/config/brokers/mt-channel-broker/deployments/broker-ingress.yaml
Lines 98 to 106 in 036711d
ports: | |
- name: http | |
port: 80 | |
protocol: TCP | |
targetPort: 8080 | |
- name: http-metrics | |
port: 9092 | |
protocol: TCP | |
targetPort: 9092 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Looks good, thanks @antoineco
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, antoineco, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proposed Changes
It isn't clear from the manifests whether 9090 or 9092 is preferred, but the correct port is 9092:
eventing/cmd/mtbroker/filter/main.go
Lines 48 to 51 in af99921
See also #3181