-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pingsource v1beta1 e2e tests #3817
pingsource v1beta1 e2e tests #3817
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lionelvillard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following jobs failed:
Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:
|
/test pull-knative-eventing-integration-tests |
/lgtm @lionelvillard IIRC the reconciler was still using the v1alpha2 version. Are you planning on changing the reconciler as well? maybe in a follow up? |
@nachocano that's right. Somehow I like to keep the reconciler and the storage version in sync, for no specific technical reasons other than the conversion webhook is then not (?) involved during the reconciliation loop. |
Ack. Just fyi we changed it for the other sources.
But I think we can wait until 0.17 is cut if you prefer to keep the storage
version and reconciler in sync.
…On Tue, Aug 11, 2020 at 12:19 PM Lionel Villard ***@***.***> wrote:
@nachocano <https://github.com/nachocano> that's right. Somehow I like to
keep the reconciler and the storage version in sync, for no specific
technical reasons other than the conversion webhook is then not (?)
involved during the reconciliation loop.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3817 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABD65DGBK5S2FEOFANPRTELSAGKV3ANCNFSM4P3DA6DQ>
.
|
For #3606
Proposed Changes
Release Note
Docs