Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pingsource v1beta1 e2e tests #3817

Merged

Conversation

lionelvillard
Copy link
Member

For #3606

Proposed Changes

  • add PingSource v1beta1 e2e tests

Release Note


Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 11, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 11, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Aug 11, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2020
@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestEventTransformationForSubscription/Channel-messaging.knative.dev/v1beta1
test/e2e.TestEventTransformationForSubscription

@lionelvillard
Copy link
Member Author

/test pull-knative-eventing-integration-tests

@nachocano
Copy link
Contributor

/lgtm

@lionelvillard IIRC the reconciler was still using the v1alpha2 version. Are you planning on changing the reconciler as well? maybe in a follow up?

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2020
@knative-prow-robot knative-prow-robot merged commit e8b5057 into knative:master Aug 11, 2020
@lionelvillard
Copy link
Member Author

@nachocano that's right. Somehow I like to keep the reconciler and the storage version in sync, for no specific technical reasons other than the conversion webhook is then not (?) involved during the reconciliation loop.

@nachocano
Copy link
Contributor

nachocano commented Aug 11, 2020 via email

@lionelvillard lionelvillard deleted the pingsource-v1beta1-e2e branch September 3, 2020 15:29
@lionelvillard lionelvillard restored the pingsource-v1beta1-e2e branch September 3, 2020 15:42
@lionelvillard lionelvillard deleted the pingsource-v1beta1-e2e branch September 3, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants