PingSource conversion v1beta1, and crd. #3744
Conversation
knative-prow-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lionelvillard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
|
||
| return nil | ||
| default: | ||
| return fmt.Errorf("Unknown conversion, got: %T", sink) |
There was a problem hiding this comment.
I think we have been doing something like apis.ConvertToViaProxy(ctx, source, &v1beta1.PingSource{}, sink)
similar thing in the ConvertFrom
There was a problem hiding this comment.
did it in v1alpha2. Thanks!
|
/lgtm |
| // in v1beta1, timezone has its own field | ||
| schedule := source.Spec.Schedule | ||
| if strings.HasPrefix(schedule, "TZ=") || strings.HasPrefix(schedule, "CRON_TZ=") { | ||
| i := strings.Index(schedule, " ") |
There was a problem hiding this comment.
nit: might be worth adding a comment with an example string, and what you are extracting from it...
can you it in a follow up, if you agree it might be useful for future maintainers
|
The following jobs failed:
Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests: |
|
/test pull-knative-eventing-integration-tests |
Part of #3606
Proposed Changes
Release Note
Docs