Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eventing v1 types to webhook config #3396

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Add eventing v1 types to webhook config #3396

merged 1 commit into from
Jun 24, 2020

Conversation

aliok
Copy link
Member

@aliok aliok commented Jun 24, 2020

Part of #3337

Proposed Changes

  • Add eventing v1 types to webhook config for defaulting, validation and conversion

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 24, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 24, 2020
@aliok
Copy link
Member Author

aliok commented Jun 24, 2020 •
edited
Loading

/assign @vaikas
/hold
let's hold for @vaikas 's review

I am working on a PR for the proper conversions. I didn't realize there was work needed there first.
UPDATE: conversion PR #3402

@vaikas
Copy link
Contributor

vaikas commented Jun 24, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2020
@knative-prow-robot knative-prow-robot merged commit c0fcc6c into knative:master Jun 24, 2020
lberk pushed a commit to lberk/eventing that referenced this pull request Jun 26, 2020
@aliok @lberk
Add eventing v1 types to webhook config (knative#3396)
35fb6ce
@aliok aliok deleted the eventing_v1_defaulting_validation_conversion branch April 28, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3wscott n3wscott Awaiting requested review from n3wscott

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@vaikas vaikas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aliok @vaikas @knative-prow-robot @googlebot