-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a job for migrating broker storage versions to v1beta1 #3262
add a job for migrating broker storage versions to v1beta1 #3262
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
||
// Package preinstall is a placeholder that allows us to pull in config files | ||
// via go mod vendor. | ||
package preinstall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the difference between "preinstall" and upgrade ?
just wondering, since we have post-install, and upgrade already. and now pre-install ?
Just wondering
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think upgrade might have been a poor name. I think it's cleaner to indicate which steps need to happen before upgrade (preinstall) and which have to happen after (postinstall). Anyways, that was my thinking :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps preupgrade / postupgrade is better? :) Since you don't need to run those if you're doing a fresh install. Serving called it post install, so went with that last time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, I like
pre-install
post-install
I just did not really like upgrade :-)
/lgtm |
/test pull-knative-eventing-upgrade-tests |
/test pull-knative-eventing-integration-tests |
Fixes #3261
Proposed Changes
Release Note
Docs
knative/docs#2543