Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Discovery: EventType Autocreate on replies to subscriptions should reference the subscription #7699

Closed
Cali0707 opened this issue Feb 16, 2024 · 8 comments · Fixed by #7733
Assignees
Labels
kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@Cali0707
Copy link
Member

Problem
To indicate that eventtypes occur in replies, we should have them reference the subscription instead of the channel.

Persona:
Which persona is this feature for?

Exit Criteria
A rekt test that shows that reply events to a subscription have the autocreated event reference the subscription, not the channel

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

Additional context (optional)
Add any other context about the feature request here.

@Cali0707
Copy link
Member Author

/triage accepted

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Feb 16, 2024
@Cali0707
Copy link
Member Author

/assign

@mgencur
Copy link
Contributor

mgencur commented Sep 10, 2024

The TestChannelSubscriptionEventTypeAutoCreate test from https://github.com/knative-extensions/eventing-kafka-broker/pull/4074/files still shows that the eventtype references a KafkaChannel instead of Subscription. See https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-extensions_eventing-kafka-broker/4074/channel-reconciler-tests-sasl-plain_eventing-kafka-broker_main/1833439756705337344

Reference:Kind = KafkaChannel, Namespace = test-shtvzyyt, Name = channel-rkavthwn

/reopen

@knative-prow knative-prow bot reopened this Sep 10, 2024
Copy link

knative-prow bot commented Sep 10, 2024

@mgencur: Reopened this issue.

In response to this:

The TestChannelSubscriptionEventTypeAutoCreate test from https://github.com/knative-extensions/eventing-kafka-broker/pull/4074/files still shows that the eventtype references a KafkaChannel instead of Subscription. See https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-extensions_eventing-kafka-broker/4074/channel-reconciler-tests-sasl-plain_eventing-kafka-broker_main/1833439756705337344

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Cali0707
Copy link
Member Author

@mgencur could you open this in EKB? The autocreate implementation in EKB is independent of the one here in eventing core

@mgencur
Copy link
Contributor

mgencur commented Sep 10, 2024

@Cali0707 Excuse me. I re-opened a wrong issue. I meant this one: knative-extensions/eventing-kafka-broker#4076

@mgencur
Copy link
Contributor

mgencur commented Sep 10, 2024

/close

@knative-prow knative-prow bot closed this as completed Sep 10, 2024
Copy link

knative-prow bot commented Sep 10, 2024

@mgencur: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants