Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove default configs for the Brokers ? #2934

Closed
matzew opened this issue Apr 7, 2020 · 1 comment · Fixed by #2936
Closed

remove default configs for the Brokers ? #2934

matzew opened this issue Apr 7, 2020 · 1 comment · Fixed by #2936

Comments

@matzew
Copy link
Member

matzew commented Apr 7, 2020

Problem

current BOTH borker impls come with some ConfigMap that sets them as default.

This is different how channels are handling it.

Perhaps we can follow that model from the channel? to explicitly have the user decide when applying a "yaml distribution" for a channel if she wants that as a default?

** Proposal / Problem **

The brokers both, come with the same configmap, with different values:

https://storage.googleapis.com/knative-nightly/eventing/latest/mt-channel-broker.yaml
https://storage.googleapis.com/knative-nightly/eventing/latest/channel-broker.yaml

so if you apply the first "distributiion", than the second "distribution, they do have effect. the later overrides the default of the first.

Currently our Channels do not do that....

No config maps in here, which does SET the channel as default

Instead we have DOC that shows how to update the related configmap to set a channel of choice as the default.

Should we do this too, @vaikas ?

@grantr
Copy link
Contributor

grantr commented Apr 7, 2020

The current scheme for default channels is:

  • In eventing-core.yaml, include a configmap that assumes InMemoryChannel is the default, but don't install InMemoryChannel.
  • In eventing.yaml include core and the InMemoryChannel.

User scenarios:

  • Anyone who installs eventing.yaml has a default channel out of the box.
  • Anyone who installs eventing.yaml and another channel MAY update the config to set the default channel.
  • Anyone who installs eventing-core.yaml MUST install a channel and update the config (if they want to use default channels).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants