Remove duplicated default configmaps, and stash them in core

[matzew]

Signed-off-by: Matthias Wessendorf [email protected]

Fixes #2934

Proposed Changes

• removes duplicated configs for both brokers.
• making (for now) the channel-broker the default

follow up issues:

• Document how to change the broker defaults docs#2371
• MT Broker the new default? #2935

[matzew]

/test pull-knative-eventing-integration-tests

[aslom]

What happens when broker and mt-broker are applied, then deleted and then applied? Is config preserved? Is it documented?

[matzew]

well, as discussed in the issue, this PR will do the same behavior for brokers, that we have for channels...

and yes, there is also a reference to an issue on docs. I will move on, with doc'ing that, once this is in.

[grantr]

Haven't had a chance to review yet, but I approve of the approach. It's worked for channels so far.

[aliok]

Maybe out of scope for this PR, but it is related: do we need to ship the MT broker as an optional thing?

With next release eventing.yaml and eventing-mt.yaml artifacts will be created.
If you apply eventing.yaml, you won't have the MTBroker.
If you apply eventing-mt.yaml, you will have the MTBroker but it won't be the default one if this PR is merged.

In last operations WG meeting, @vaikas was saying that we want to support the scenario that both brokers exist in a Knative installation.

So, my suggestion is that we also modify this part:

eventing/hack/release.sh

Line 37 in 9bf9bb5

["eventing-mt.yaml"]="eventing-core.yaml mt-channel-broker.yaml in-memory-channel.yaml"

so that there will be a single eventing.yaml which has both brokers. And, what the default broker will be is defined as with the config-br-defaults configmap.

[matzew]

ah, good point @aliok - I did touch that file too, now

[antoineco]

Looks good to me!

Just one comment. Shouldn't all configurations be created under config/core/configmaps and then symlinked inside config/? I see that most other manifests are symlinked that way.

[vaikas]

For some reason I'm unable to add this comment using github comments, but here:
config/400-config-br-defaults.yaml
L21 comment seems wrong and a carry over from somewhere else?
I'm fine with fixing later.

[vaikas]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [matzew,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment