Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

KnativeEventing api files live in wrong directory #128

Closed
aliok opened this issue Mar 10, 2020 · 2 comments
Closed

KnativeEventing api files live in wrong directory #128

aliok opened this issue Mar 10, 2020 · 2 comments

Comments

@aliok
Copy link
Member

aliok commented Mar 10, 2020

Exactly the same problem with knative/serving-operator#336 of serving operator

Problem
KnativeEventng api files live in wrong directory.

Its group is operator.knative.dev but the api files are in pkg/apis/eventing/...
They should be in pkg/apis/operator/..

This is a better practice and some tools like operator-sdk is expecting that kind of consistent directory tree when generating some metadata. See operator-framework/operator-sdk#2511 (comment)

Persona:
Contributors

Exit Criteria
Have the directory name changed and have the tests passing.

Time Estimate (optional):
0.5 developer-day

Additional context (optional)
None

@aliok aliok changed the title KnativeServing api files live in wrong directory KnativeEventing api files live in wrong directory Mar 10, 2020
@aliok
Copy link
Member Author

aliok commented Apr 10, 2020

/close

In the new operator I see this is fixed. https://github.com/knative-sandbox/operator

@knative-prow-robot
Copy link
Contributor

@aliok: Closing this issue.

In response to this:

/close

In the new operator I see this is fixed. https://github.com/knative-sandbox/operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants