Make githubsource's SecretToken optional

[duglin]

Right now SecretToken appears to be required:
https://github.com/knative/eventing-sources/blob/master/pkg/apis/sources/v1alpha1/githubsource_types.go#L66

I think it would be nice if it were made optional, and if not provided then the system just created something to use (like a UUID). This value has no meaning outside of this subscription so I don't need the requirement to force the user to specify it. However, if someone does want to do so they can.

[n3wscott]

gcppubsubsource has been removed from this repo. Please see http://github.com/google/knative-gcp

PullSubscription is the replacement.

/close

[knative-prow-robot]

@n3wscott: Closing this issue.

In response to this:

gcppubsubsource has been removed from this repo. Please see http://github.com/google/knative-gcp

PullSubscription is the replacement.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[duglin]

@n3wscott I think you closed this one by mistake - this isn't about gcp

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[duglin]

/remove-lifecycle stale

[lionelvillard]

move to knative-sandbox/eventing-github: knative-extensions/eventing-github#36