Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken formatting in Installing guide #4917

Merged
merged 6 commits into from
Apr 15, 2022
Merged

Fix broken formatting in Installing guide #4917

merged 6 commits into from
Apr 15, 2022

Commits on Apr 8, 2022

  1. Task1 done 

    “Installing Istio without sidecar injection(Recommended default installation)” added a space before the opening parenthesis.
    @Subhasish-Behera
    Subhasish-Behera authored Apr 8, 2022
    Configuration menu
    Copy the full SHA
    4a5302c View commit details
    Browse the repository at this point in the history

  2. Task 2 

    Correct formatting uses the opening tip tag (!!! tip), followed by a new line, and then 4 spaces before the tip text.
    @Subhasish-Behera
    Subhasish-Behera authored Apr 8, 2022
    Configuration menu
    Copy the full SHA
    3bddab5 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2022

  1. Task 4 

     Task fixed: https://knative.dev/docs/install/uninstall/#uninstalling-optional-serving-extensions Broken numbering in the "TLS with cert-manager" tab. To fix, check for the correct indentation of the code snippet (8 spaces).
    @Subhasish-Behera
    Subhasish-Behera authored Apr 9, 2022
    Configuration menu
    Copy the full SHA
    87a55fb View commit details
    Browse the repository at this point in the history

  2. Task 5 

    Task fixed:  https://knative.dev/docs/install/uninstall/#uninstalling-optional-eventing-extensions broken numbering in Apace Kafka sink tab. To fix, check for the correct indentation of the code snippet (8 spaces).
    @Subhasish-Behera
    Subhasish-Behera authored Apr 9, 2022
    Configuration menu
    Copy the full SHA
    f519b5f View commit details
    Browse the repository at this point in the history

  3. Task 3 

    Task fixed:  https://knative.dev/docs/install/upgrade/upgrade-installation-with-operator/#rollback-to-an-earlier-version tab formatting is broken. To fix, indent the lines 126-146 and 150-170 by an extra 4 spaces.
    @Subhasish-Behera
    Subhasish-Behera authored Apr 9, 2022
    Configuration menu
    Copy the full SHA
    62adc0a View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2022

  1. changed the spacing according to the suggestion 

    Co-authored-by: Samia Nneji <[email protected]>
    @Subhasish-Behera @snneji
    Subhasish-Behera and snneji authored Apr 12, 2022
    Configuration menu
    Copy the full SHA
    82fb3d1 View commit details
    Browse the repository at this point in the history