Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed step 1 of creating service #4914

Merged
merged 2 commits into from
Apr 11, 2022
Merged

removed step 1 of creating service #4914

merged 2 commits into from
Apr 11, 2022

Conversation

Subhasish-Behera
Copy link
Contributor

fixes #4891

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 8, 2022
@knative-prow
Copy link

knative-prow bot commented Apr 8, 2022

Hi @Subhasish-Behera. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 8, 2022
@netlify
Copy link

netlify bot commented Apr 8, 2022 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 389ad9c
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/62511ec8d58c29000a98563c
😎 Deploy Preview https://deploy-preview-4914--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@psschwei
Copy link
Contributor

psschwei commented Apr 8, 2022

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 8, 2022
psschwei
psschwei requested changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! See the comment below about numbering...

docs/eventing/sources/kafka-source/README.md Outdated
@@ -116,7 +106,7 @@ If you are using Strimzi:
image: gcr.io/knative-releases/knative.dev/eventing/cmd/event_display
```

1. Apply the YAML file by running the command:
2. Apply the YAML file by running the command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown / mkdocs should convert the numbers to the correct ones on when the site is published, so we should leave all these as 1. xxxxx (or update the ones that weren't to 1. xxxxx

@Subhasish-Behera
implemented the suggested changes
389ad9c 
changed the numbering back to 1
psschwei
psschwei reviewed Apr 11, 2022
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2022
@knative-prow
Copy link

knative-prow bot commented Apr 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psschwei, Subhasish-Behera

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2022
@knative-prow knative-prow bot merged commit 3ca065c into knative:main Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei requested changes

Assignees

@psschwei psschwei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

in doc-->eventing-->developer topics-->Event source-->kafka source, there is a error
2 participants
@Subhasish-Behera @psschwei