-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update serving tutorial #4815
Update serving tutorial #4815
Conversation
✅ Deploy Preview for knative ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csantanapr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold I think I will change it to a story that starts with 0% traffic and tag for the new version hello-00002 and the user first test the new version before making available to anyone, then increase from 0% to 50% then finishing with 100% to latest v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these improvements!
I've made some suggestions to improve consistency and style.
I think there are some other useful things in this PR such improving the curl commands for minikube. Do you plan to remove the tag parts from this PR so that we can merge the rest? |
I will create a new PR for the tag stuff, and remove it from this one |
@snneji thank you for the review, can you PTAL when you have a chance |
Signed-off-by: Carlos Santana <[email protected]>
892ceb1
to
7f35dc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more small changes. Otherwise looks good.
Signed-off-by: Carlos Santana <[email protected]>
@snneji please review I addressed all your suggestions, thank you for the review |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csantanapr, snneji The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@csantanapr is this ready to merge? |
/unhold |
/cherry-pick release-1.3 |
@csantanapr: new pull request created: #4888 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is part of the epic #4553
Fixes #4245 #4740 #4612
This PR addresses
kn quickstart