Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serving tutorial #4815

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Conversation

csantanapr
Copy link
Member

@csantanapr csantanapr commented Mar 10, 2022

This is part of the epic #4553

Fixes #4245 #4740 #4612

This PR addresses

@netlify
Copy link

netlify bot commented Mar 10, 2022

Deploy Preview for knative ready!

Name Link
🔨 Latest commit 9659c89
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6242013de02c59000a215ec7
😎 Deploy Preview https://deploy-preview-4815--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csantanapr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 10, 2022
@csantanapr
Copy link
Member Author

/hold
Now thinking about tag based routing it doesn’t make sense at the end.

I think I will change it to a story that starts with 0% traffic and tag for the new version hello-00002 and the user first test the new version before making available to anyone, then increase from 0% to 50% then finishing with 100% to latest v2

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2022
Copy link
Contributor

@snneji snneji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these improvements!

I've made some suggestions to improve consistency and style.

docs/snippets/quickstart-install.md Outdated Show resolved Hide resolved
docs/snippets/quickstart-install.md Outdated Show resolved Hide resolved
docs/getting-started/first-traffic-split.md Outdated Show resolved Hide resolved
docs/getting-started/first-traffic-split.md Outdated Show resolved Hide resolved
docs/getting-started/first-traffic-split.md Outdated Show resolved Hide resolved
docs/getting-started/first-traffic-split.md Outdated Show resolved Hide resolved
docs/getting-started/first-traffic-split.md Outdated Show resolved Hide resolved
docs/getting-started/first-traffic-split.md Outdated Show resolved Hide resolved
docs/getting-started/first-traffic-split.md Outdated Show resolved Hide resolved
docs/getting-started/first-traffic-split.md Outdated Show resolved Hide resolved
@snneji
Copy link
Contributor

snneji commented Mar 10, 2022

/hold Now thinking about tag based routing it doesn’t make sense at the end.

I think I will change it to a story that starts with 0% traffic and tag for the new version hello-00002 and the user first test the new version before making available to anyone, then increase from 0% to 50% then finishing with 100% to latest v2

I think there are some other useful things in this PR such improving the curl commands for minikube. Do you plan to remove the tag parts from this PR so that we can merge the rest?

@csantanapr
Copy link
Member Author

I will create a new PR for the tag stuff, and remove it from this one

@csantanapr
Copy link
Member Author

@snneji thank you for the review, can you PTAL when you have a chance

@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 22, 2022
Signed-off-by: Carlos Santana <[email protected]>
@csantanapr csantanapr force-pushed the quickstart-minikube branch from 892ceb1 to 7f35dc5 Compare March 22, 2022 22:47
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 22, 2022
Copy link
Contributor

@snneji snneji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more small changes. Otherwise looks good.

docs/snippets/quickstart-install.md Outdated Show resolved Hide resolved
docs/snippets/quickstart-install.md Outdated Show resolved Hide resolved
docs/getting-started/first-traffic-split.md Outdated Show resolved Hide resolved
docs/getting-started/first-traffic-split.md Outdated Show resolved Hide resolved
docs/getting-started/first-traffic-split.md Outdated Show resolved Hide resolved
Signed-off-by: Carlos Santana <[email protected]>
@csantanapr
Copy link
Member Author

@snneji please review I addressed all your suggestions, thank you for the review

@snneji
Copy link
Contributor

snneji commented Mar 29, 2022

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@knative-prow
Copy link

knative-prow bot commented Mar 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csantanapr, snneji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@snneji
Copy link
Contributor

snneji commented Mar 31, 2022

@csantanapr is this ready to merge?

@csantanapr
Copy link
Member Author

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2022
@knative-prow knative-prow bot merged commit 7425ab0 into knative:main Mar 31, 2022
@csantanapr
Copy link
Member Author

/cherry-pick release-1.3

@knative-prow-robot
Copy link
Contributor

@csantanapr: new pull request created: #4888

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include minimum system requirements in Getting Started guide(s)
3 participants