Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate the install guides. #2170

Merged
merged 3 commits into from
Feb 6, 2020
Merged

Consolidate the install guides. #2170

merged 3 commits into from
Feb 6, 2020

Conversation

mattmoor
Copy link
Member

@mattmoor mattmoor commented Feb 4, 2020

This builds on #2155 to make the consolidated guide the only guide.

WIP because the base needs to land, and I'm just trying to see how this looks right now.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 4, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 4, 2020
@mattmoor mattmoor force-pushed the drop-other-guides branch 10 times, most recently from 85be570 to 7023ee6 Compare February 5, 2020 00:02
@mattmoor mattmoor changed the title [WIP] Consolidate the install guides. Consolidate the install guides. Feb 5, 2020
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Feb 5, 2020

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2020
@mattmoor mattmoor force-pushed the drop-other-guides branch 2 times, most recently from ef548aa to 1301f6b Compare February 5, 2020 04:55
mattmoor
mattmoor commented Feb 5, 2020
View reviewed changes
Copy link
Member Author

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started to fill in some of the pieces from the "custom install" page, so that we can drop it in favor of the consolidated install page.

I'm somewhat inclined to land this PR with TODOs (which I've tagged OWNERS on here), and ask that folks send a PR to address each gap. My goal is to delete the custom install page before 0.13 cuts, and have everything we want to keep in the consolidated install guide.

docs/install/knative-with-any-k8s.md
@@ -344,6 +344,9 @@ The following command installs an implementation of Channel that runs in-memory.
{{< /tab >}}

<!-- TODO(https://github.com/knative/docs/issues/2153): Add more Channels here -->
<!-- TODO: Kafka Channel -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @matzew @lberk @bbrowning (OWNERS)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matzew can you try to land https://github.com/matzew/docs/tree/add_kafka_install_script/docs/eventing/samples/kafka#setting-up-apache-kafka here after this PR lands?

docs/install/knative-with-any-k8s.md Show resolved Hide resolved
docs/install/knative-with-any-k8s.md Outdated Show resolved Hide resolved
docs/install/knative-with-any-k8s.md
@@ -344,6 +344,9 @@ The following command installs an implementation of Channel that runs in-memory.
{{< /tab >}}

<!-- TODO(https://github.com/knative/docs/issues/2153): Add more Channels here -->
<!-- TODO: Kafka Channel -->
<!-- TODO: NATSS Channel -->
<!-- TODO: GCP Pub/Sub Channel -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @grantr

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

docs/install/knative-with-any-k8s.md
@@ -344,6 +344,9 @@ The following command installs an implementation of Channel that runs in-memory.
{{< /tab >}}

<!-- TODO(https://github.com/knative/docs/issues/2153): Add more Channels here -->
<!-- TODO: Kafka Channel -->
<!-- TODO: NATSS Channel -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @Abd4llA (OWNERS)

docs/install/knative-with-any-k8s.md Outdated Show resolved Hide resolved
@mattmoor
Copy link
Member Author

mattmoor commented Feb 5, 2020

/retest

@mattmoor
Copy link
Member Author

mattmoor commented Feb 6, 2020

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2020
@samodell
Copy link
Contributor

samodell commented Feb 6, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2020
@knative-prow-robot knative-prow-robot merged commit dcaf0b8 into knative:master Feb 6, 2020
@mattmoor mattmoor deleted the drop-other-guides branch February 6, 2020 17:32
@SD-13 SD-13 mentioned this pull request Dec 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nachocano nachocano Awaiting requested review from nachocano

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@samodell samodell

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattmoor @knative-prow-robot @samodell @nachocano @googlebot