Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update knative install using Gloo #2098

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Update knative install using Gloo #2098

merged 1 commit into from
Jan 21, 2020

Conversation

MIBc
Copy link
Contributor

@MIBc MIBc commented Jan 13, 2020

Proposed Changes

  • Update shell glooctl install knative, the previous one only install
    knative-serving.
  • Update outdated url.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 13, 2020
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 13, 2020
@knative-prow-robot
Copy link
Contributor

Hi @MIBc. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 13, 2020
@MIBc
Copy link
Contributor Author

MIBc commented Jan 14, 2020

/assign @averikitsch

samodell
samodell suggested changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@samodell samodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo fix; otherwise this looks good to go

docs/install/Knative-with-Gloo.md Outdated Show resolved Hide resolved
@samodell samodell assigned samodell and unassigned averikitsch Jan 14, 2020
@samodell
Copy link
Contributor

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 14, 2020
@MIBc
Update knative install using Gloo
ef380e7 
1. Update shell `glooctl install knative`, the previous one only install
knative-serving.
2. Update outdated url
@MIBc MIBc closed this Jan 17, 2020
@MIBc MIBc reopened this Jan 17, 2020
@MIBc
Copy link
Contributor Author

MIBc commented Jan 19, 2020

@samodell Do you have any other suggestions？

@samodell
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MIBc, samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 652a2c4 into knative:master Jan 21, 2020
@MIBc MIBc deleted the gloo-install branch January 22, 2020 01:51
@MIBc MIBc mentioned this pull request Aug 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samodell samodell samodell requested changes

Assignees

@samodell samodell

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MIBc @knative-prow-robot @samodell @googlebot @averikitsch