Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added kn-plugin-source-pkg to knative-sandbox #297

Merged
merged 1 commit into from
Sep 30, 2020
Merged

added kn-plugin-source-pkg to knative-sandbox #297

merged 1 commit into from
Sep 30, 2020

Conversation

maximilien
Copy link
Contributor

@maximilien maximilien commented Sep 29, 2020 •
edited
Loading

Issue: #282

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 29, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 29, 2020
@maximilien
Copy link
Contributor Author

Once accepted and created I will push common code and submit separate requests for plugins: #169 and #284

tcnghia
tcnghia approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@tcnghia tcnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 30, 2020
@knative-prow-robot knative-prow-robot merged commit 60b3821 into knative:master Sep 30, 2020
@maximilien
Copy link
Contributor Author

Thanks @tcnghia 🙏🏽

daisy-ycguo pushed a commit to daisy-ycguo/community that referenced this pull request Mar 12, 2021
@kramvan1
Add myself as member (knative#297)
3f674ca 
If you are joining the org, please fill out the template below:

 - [x] I have reviewed the community membership guidelines
 - [x] I have reviewed the contribution guidelines
 - [x] I have enabled 2FA on my GitHub account
 - [x] I have joined the Istio discussion board and subscribed to the Contributors category
 - [x] I have joined Istio's Slack workspace (fill-out this form to join)
List your company name, or indicate Individual if you're not affiliated with a company:

IBM

Provide a link to at least one PR that you have successfully pushed to one
of the Istio repos:
istio/istio.io#22051 (Merged)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcnghia tcnghia tcnghia approved these changes

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

Assignees

@tcnghia tcnghia

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximilien @knative-prow-robot @tcnghia @googlebot