Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make API parameter type public #996

Merged
merged 1 commit into from
Sep 2, 2020
Merged

fix: Make API parameter type public #996

merged 1 commit into from
Sep 2, 2020

Conversation

rhuss
Copy link
Contributor

@rhuss rhuss commented Sep 1, 2020

Fixes #988

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 1, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 1, 2020
@rhuss
Copy link
Contributor Author

rhuss commented Sep 1, 2020

/retest

navidshaikh
navidshaikh approved these changes Sep 2, 2020
View reviewed changes
Copy link
Collaborator

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit c801e82 into knative:master Sep 2, 2020
rhuss added a commit to rhuss/knative-client that referenced this pull request Sep 9, 2020
@rhuss
fix: Make API parameter type public (knative#996)
24e84fb 
Fixes knative#988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navidshaikh navidshaikh navidshaikh approved these changes

@cppforlife cppforlife Awaiting requested review from cppforlife

@maximilien maximilien Awaiting requested review from maximilien

Assignees

@navidshaikh navidshaikh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KnServingClient::UpdateServiceWithRetry signature references private function type
4 participants
@rhuss @knative-prow-robot @navidshaikh @googlebot