Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup eventing extension: sugar controller #920

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Setup eventing extension: sugar controller #920

merged 1 commit into from
Jul 7, 2020

Conversation

navidshaikh
Copy link
Collaborator

Description

We'll need sugar controller for reconciling broker for tests
which labels namespace and annotates the triggers.

Currently, sugar controller is not part of the eventing nightly release setup
by test-infra libs. This changeset adds install of same for nightly
CI setup.

@navidshaikh
Setup eventing extension sugar controller
71ceed0 
 We'll need sugar controller for reconciling broker for tests
 which labels namespace and annotates the triggers.

 Currently, sugar controller is not part of the eventing nightly release setup
 by test-infra libs. This changeset adds install of same for nightly
 CI setup.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 7, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 7, 2020
rhuss
rhuss approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 1a8cf96 into knative:master Jul 7, 2020
@navidshaikh navidshaikh deleted the pr/sugar-controller branch July 7, 2020 19:48
@n3wscott
Copy link
Contributor

n3wscott commented Jul 7, 2020

thanks, and sorry

mgencur pushed a commit to openshift-knative/client that referenced this pull request Nov 21, 2022
@cardil
[0.26] Embed Kn Plugin Event at ffdcc78 (knative#920)
9fb3b22 
Changes:

 * knative-extensions/kn-plugin-event#133 (backported via openshift-knative/kn-plugin-event#22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhuss rhuss rhuss approved these changes

@maximilien maximilien Awaiting requested review from maximilien

Assignees

@rhuss rhuss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@navidshaikh @knative-prow-robot @n3wscott @rhuss @googlebot