Find sink and ready conditions for untyped source

[navidshaikh]

Description

[kn source list] Improve extraction of source instance's sink and ready status

Changes

• Look up spec.sink field in untyped source unstructured object and
  try to convert it to duck Destination object
• Look up status.conditions field in untyped source unstructured object and
  try to convert it to duck Conditions object
• Upon not finding the data at expected fields, return "<unknown>"

Example:

Before:

kn source list --type kafkasource
NAME         TYPE          RESOURCE                           SINK        READY
k1           KafkaSource   kafkasources.sources.knative.dev   <unknown>   <unknown>
mykafkasrc   KafkaSource   kafkasources.sources.knative.dev   <unknown>   <unknown>
seeder       KafkaSource   kafkasources.sources.knative.dev   <unknown>   <unknown>

After:

kn source list --type kafkasource
NAME         TYPE          RESOURCE                           SINK                READY
k1           KafkaSource   kafkasources.sources.knative.dev   svc:event-display   True
mykafkasrc   KafkaSource   kafkasources.sources.knative.dev                       False
seeder       KafkaSource   kafkasources.sources.knative.dev   broker:relay        True

Reference

Fixes #909

/lint

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow-robot]

@navidshaikh: 0 warnings.

In response to this:

Description

[kn source list] Improve extraction of source instance's sink and ready status

Changes

• Look up spec.sink field in untyped source unstructured object and
  try to convert it to duck Destination object
• Look up status.conditions field in untyped source unstructured object and
  try to convert it to duck Conditions object
• Upon not finding the data at expected fields, return ""

Example:

Before:

kn source list --type kafkasource
NAME         TYPE          RESOURCE                           SINK        READY
k1           KafkaSource   kafkasources.sources.knative.dev   <unknown>   <unknown>
mykafkasrc   KafkaSource   kafkasources.sources.knative.dev   <unknown>   <unknown>
seeder       KafkaSource   kafkasources.sources.knative.dev   <unknown>   <unknown>

After:

kn source list --type kafkasource
NAME         TYPE          RESOURCE                           SINK                READY
k1           KafkaSource   kafkasources.sources.knative.dev   svc:event-display   True
mykafkasrc   KafkaSource   kafkasources.sources.knative.dev                       False
seeder       KafkaSource   kafkasources.sources.knative.dev   broker:relay        True

Reference

Fixes #909

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[navidshaikh]

please take a look and if you have any comments about the approach?

[maximilien]

Lack of testing... See comments. Perhaps not all can be easily covered but we should attempt some if possible. Thank you.

[maximilien]

Nice work @navidshaikh. Please update the copyright and otherwise LGTM

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/source/duck/multisourcelist.go	Do not exist	78.4%

[navidshaikh]

/retest

Error: Operation cannot be fulfilled on triggers.eventing.knative.dev "filtertrigger": the object has been modified; please apply your changes to the latest version and try again

[maximilien]

/lgtm