Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release(0.15.1): Backport fix for resource flags names #873

Merged
merged 1 commit into from
Jun 3, 2020
Merged

release(0.15.1): Backport fix for resource flags names #873

merged 1 commit into from
Jun 3, 2020

Conversation

navidshaikh
Copy link
Collaborator

Cherry-pick: c1ab4ae

@navidshaikh
Update flag names to --request and --limit (knative#872)
bb2d54a 
* Update flag names to --request and --limit

 - Use singular flag names and support comma separated or repeated flag values
 - Update tests and docs

* Update CHANGELOG

* Update the flag description and examples

* Remove release 0.15.0 header from CHANGELOG
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 3, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 3, 2020
@navidshaikh navidshaikh changed the title release(0.15.0): Backport fixes for resource flag names release(0.15.0): Backport fix for resource flag names Jun 3, 2020
@navidshaikh navidshaikh changed the title release(0.15.0): Backport fix for resource flag names release(0.15.0): Backport fix for resource flags names Jun 3, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/flags/resources.go 100.0% 96.6% -3.4
pkg/serving/config_changes.go 76.7% 75.8% -0.9

@navidshaikh navidshaikh changed the title release(0.15.0): Backport fix for resource flags names release(0.15.1): Backport fix for resource flags names Jun 3, 2020
@rhuss
Copy link
Contributor

rhuss commented Jun 3, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2020
@knative-prow-robot knative-prow-robot merged commit 0cac223 into knative:release-0.15 Jun 3, 2020
@navidshaikh navidshaikh deleted the pr/0.15-backports branch June 3, 2020 13:23
dsimansk added a commit to dsimansk/client that referenced this pull request Dec 7, 2021
@dsimansk
[release-v0.26.1] Fix grpc-ping image ref (knative#873)
958a755 
* [release-v0.26.1] Fix grpc-ping image ref

* Fix Makefile to build grpc-ping from vendor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@sixolet sixolet Awaiting requested review from sixolet

Assignees

@rhuss rhuss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@navidshaikh @knative-prow-robot @knative-metrics-robot @rhuss @googlebot