Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNM: Run serving specific e2e tests using tags #830

Closed
wants to merge 2 commits into from
Closed

DNM: Run serving specific e2e tests using tags #830

wants to merge 2 commits into from

Conversation

navidshaikh
Copy link
Collaborator

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 7, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 7, 2020
maximilien
maximilien approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this and would even split the eventing-e2e into their own so that we could do something like: ./hack/build.sh --eventing-e2e or similar.

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maximilien,navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maximilien
Copy link
Contributor

/retest

@navidshaikh
Copy link
Collaborator Author

navidshaikh commented May 8, 2020 •
edited
Loading

I like this and would even split the eventing-e2e into their own so that we could do something like: ./hack/build.sh --eventing-e2e or similar.

@maximilien : We already have this using go tags. You can set eventing or serving to E2E_TAGS and run as:

E2E_TAGS=eventing ./test/local-e2e-tests.sh

#832 should fix issue of any non-scoped method being referenced in scoped tags.

@navidshaikh navidshaikh mentioned this pull request May 13, 2020
Closed
@knative-prow-robot
Copy link
Contributor

@navidshaikh: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-client-integration-tests af38e6e link /test pull-knative-client-integration-tests
pull-knative-client-integration-tests-latest-release af38e6e link /test pull-knative-client-integration-tests-latest-release

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@navidshaikh
Copy link
Collaborator Author

@coryrc : I've opened this PR to re-produce issue mentioned in knative/test-infra#2064

@navidshaikh
Copy link
Collaborator Author

/close

Closing the PR, knative/test-infra#2064 can be re-produced as mentioned in this PR.
cc: @chizhg @chaodaiG

@knative-prow-robot
Copy link
Contributor

@navidshaikh: Closed this PR.

In response to this:

/close

Closing the PR, knative/test-infra#2064 can be re-produced as mentioned in this PR.
cc: @chizhg @chaodaiG

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilien maximilien maximilien approved these changes

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@navidshaikh @knative-prow-robot @maximilien @googlebot