Update flag resource description in apiserver source command
#817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/S
rhuss
reviewed
Apr 21, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: daisy-ycguo, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
maximilien
pushed a commit
to maximilien/client
that referenced
this pull request
Apr 21, 2020
coryrc
pushed a commit
to coryrc/client
that referenced
this pull request
May 14, 2020
UnmarshalStrict returns error when encountering unknown field from yaml. It's a good way to catch mis-spelt and unsupported field names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since
isControlleris changed toLabelSelectorin API v1alpha2, the flag description shall be updated to match the changes. Some minor changes are made to completely remove isController from apiserver source command group.Changes
resourcein apiserver source command.