Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Foreground delete for revisions and services in e2e #794

Merged
merged 2 commits into from
Apr 15, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/basic_workflow_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func serviceUpdate(r *test.KnRunResultCollector, serviceName string, args ...str
}

func serviceDelete(r *test.KnRunResultCollector, serviceName string) {
out := r.KnTest().Kn().Run("service", "delete", serviceName)
out := r.KnTest().Kn().Run("service", "delete", "--wait", serviceName)
r.AssertNoError(out)
assert.Check(r.T(), util.ContainsAll(out.Stdout, "Service", serviceName, "successfully deleted in namespace", r.KnTest().Kn().Namespace()))
}
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/revision_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func revisionListWithService(r *test.KnRunResultCollector, serviceNames ...strin
}

func revisionDelete(r *test.KnRunResultCollector, revName string) {
out := r.KnTest().Kn().Run("revision", "delete", revName)
out := r.KnTest().Kn().Run("revision", "delete", "--wait", revName)
assert.Check(r.T(), util.ContainsAll(out.Stdout, "Revision", revName, "deleted", "namespace", r.KnTest().Kn().Namespace()))
r.AssertNoError(out)
}
Expand Down