Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix changelog on master #760

Merged
merged 3 commits into from
Mar 25, 2020
Merged

chore: Fix changelog on master #760

merged 3 commits into from
Mar 25, 2020

Conversation

rhuss
Copy link
Contributor

@rhuss rhuss commented Mar 25, 2020

No description provided.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 25, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 25, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2020
navidshaikh
navidshaikh reviewed Mar 25, 2020
View reviewed changes
CHANGELOG.adoc Outdated Show resolved Hide resolved
@navidshaikh
Copy link
Collaborator

navidshaikh commented Mar 25, 2020 •
edited
Loading

Along with only markdown file changes, adoc only changes can also be considered as docs-only PR to skip the e2e tests.
cc: @chizhg @chaodaiG

@rhuss @navidshaikh
Update CHANGELOG.adoc
4b614e4 
Co-Authored-By: Navid Shaikh <[email protected]>
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 25, 2020
@dsimansk
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2020
@knative-prow-robot knative-prow-robot merged commit 521a0b4 into knative:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navidshaikh navidshaikh navidshaikh left review comments

@mattmoor mattmoor Awaiting requested review from mattmoor

@maximilien maximilien Awaiting requested review from maximilien

Assignees

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rhuss @knative-prow-robot @navidshaikh @dsimansk @googlebot