Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(trigger): Fix filter delete for trigger update #746

Merged
merged 1 commit into from
Mar 18, 2020
Merged

fix(trigger): Fix filter delete for trigger update #746

merged 1 commit into from
Mar 18, 2020

Conversation

dsimansk
Copy link
Contributor

Description

Fix TriggerBuilder.Filter to actually replace map on update.

Changes

  • Fix filter delete via --filter key- flag

Reference

Fixes #743

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 18, 2020
knative-prow-robot
knative-prow-robot reviewed Mar 18, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsimansk: 0 warnings.

In response to this:

Description

Fix TriggerBuilder.Filter to actually replace map on update.

Changes

  • Fix filter delete via --filter key- flag

Reference

Fixes #743

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 18, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/eventing/v1alpha1/client.go 83.9% 83.1% -0.8

maximilien
maximilien approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks for finding this

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2020
@knative-prow-robot knative-prow-robot merged commit 1b0e712 into knative:master Mar 18, 2020
dsimansk added a commit to dsimansk/client that referenced this pull request Mar 19, 2020
@dsimansk
fix(trigger): Fix filter delete for trigger update (knative#746)
d5427b5
knative-prow-robot pushed a commit that referenced this pull request Mar 24, 2020
@dsimansk @MIBc
fix(trigger): Backport trigger filter fixes (#749)
6e3fac0 
* fix(trigger): Make --filter flag truly optional (#745)

* fix(trigger): Make --filter flag truly optional

* fix(trigger): Update trigger docs

* chore: Update changelog

* fix(trigger): Fix filter delete for trigger update (#746)

* chore: Update changelog

* Fix plugin execution for Windows (#738)

Fixes #737

* Use exec.Command instend of syscall.Exec for windows.
* Fix a bug in plugin handler test when running it on windows.
* Fix typo.

* fix: Fix default config path on Windows (#752)

Co-authored-by: Lv Jiawei <[email protected]>
@navidshaikh navidshaikh added the backport/pr A backport PR which is target to a release branch. label Apr 20, 2020
@rhuss rhuss added backported-to/0.13 and removed backport/pr A backport PR which is target to a release branch. labels Apr 20, 2020
mgencur pushed a commit to openshift-knative/client that referenced this pull request Nov 21, 2022
@dsimansk
[release-v0.22.0] Update CI setup to OSS 1.16 (knative#746)
72c6787
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@maximilien maximilien maximilien approved these changes

@mattmoor mattmoor Awaiting requested review from mattmoor

@rhuss rhuss Awaiting requested review from rhuss

Assignees

@maximilien maximilien

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kn trigger update doesn't remove filter
7 participants
@dsimansk @knative-metrics-robot @knative-prow-robot @maximilien @rhuss @navidshaikh @googlebot